Skip to content

feat: support custom strategies on a queue#134

Merged
skeggse merged 1 commit intobee-queue:masterfrom
calebboyd:own-strategies
Nov 2, 2020
Merged

feat: support custom strategies on a queue#134
skeggse merged 1 commit intobee-queue:masterfrom
calebboyd:own-strategies

Conversation

@calebboyd
Copy link
Copy Markdown
Contributor

Enables providing a custom function to determine an appropriate delay.
Must be set on all queue instances.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 13, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 02780d3 on calebboyd:own-strategies into bb31bca on bee-queue:master.

@calebboyd calebboyd force-pushed the own-strategies branch 2 times, most recently from 640d475 to 49e5c5c Compare July 16, 2018 19:17
Copy link
Copy Markdown
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept seems good to me - apologies for never seeing/reviewing this. Mostly just wondering about the failure case.

@skeggse skeggse force-pushed the own-strategies branch 2 times, most recently from dd28082 to 95525f0 Compare November 2, 2020 04:29
@skeggse skeggse self-assigned this Nov 2, 2020
@skeggse skeggse merged commit 926de9d into bee-queue:master Nov 2, 2020
beequeueci pushed a commit that referenced this pull request Nov 2, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-02)

### Features

* implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d))
* support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d))
* **types:** add generics to type definitions ([a565d3d](a565d3d))
* **types:** add isRunning ([c488385](c488385))
* **types:** add ready handler ([32c4b1e](32c4b1e))

### Bug Fixes

* **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f))
* **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904))
* **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87))
* **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52))
* **types:** update createJob handler for consistency ([b71a993](b71a993))
* **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d))
* **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca))
* misc edge case fixes ([a2df983](a2df983))
* update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
beequeueci pushed a commit that referenced this pull request Nov 3, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-03)

### Features

* implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d))
* support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d))
* **types:** add generics to type definitions ([a565d3d](a565d3d))
* **types:** add isRunning ([c488385](c488385))
* **types:** add ready handler ([32c4b1e](32c4b1e))

### Bug Fixes

* **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f))
* **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904))
* **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87))
* **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52))
* **types:** update createJob handler for consistency ([b71a993](b71a993))
* **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d))
* **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca))
* misc edge case fixes ([a2df983](a2df983))
* update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
@beequeueci
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants