Skip to content

fix(removeJob): remove job from stored jobs#230

Merged
skeggse merged 1 commit intomasterfrom
fix-job-removal
Apr 17, 2020
Merged

fix(removeJob): remove job from stored jobs#230
skeggse merged 1 commit intomasterfrom
fix-job-removal

Conversation

@skeggse
Copy link
Copy Markdown
Member

@skeggse skeggse commented Apr 16, 2020

Fixes #150.

@skeggse skeggse requested review from hughsw and shils April 16, 2020 19:06
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 16, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 4f2f824 on fix-job-removal into bc8aa52 on master.

@skeggse skeggse added the bug label Apr 16, 2020
@skeggse skeggse self-assigned this Apr 16, 2020
@skeggse skeggse added this to the 1.2.4 milestone Apr 16, 2020
@skeggse skeggse merged commit a8c9d87 into master Apr 17, 2020
@skeggse skeggse deleted the fix-job-removal branch April 17, 2020 00:02
beequeueci pushed a commit that referenced this pull request Nov 2, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-02)

### Features

* implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d))
* support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d))
* **types:** add generics to type definitions ([a565d3d](a565d3d))
* **types:** add isRunning ([c488385](c488385))
* **types:** add ready handler ([32c4b1e](32c4b1e))

### Bug Fixes

* **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f))
* **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904))
* **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87))
* **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52))
* **types:** update createJob handler for consistency ([b71a993](b71a993))
* **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d))
* **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca))
* misc edge case fixes ([a2df983](a2df983))
* update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
beequeueci pushed a commit that referenced this pull request Nov 3, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-03)

### Features

* implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d))
* support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d))
* **types:** add generics to type definitions ([a565d3d](a565d3d))
* **types:** add isRunning ([c488385](c488385))
* **types:** add ready handler ([32c4b1e](32c4b1e))

### Bug Fixes

* **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f))
* **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904))
* **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87))
* **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52))
* **types:** update createJob handler for consistency ([b71a993](b71a993))
* **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d))
* **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca))
* misc edge case fixes ([a2df983](a2df983))
* update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
@beequeueci
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@skeggse skeggse modified the milestones: 1.2.4, 1.3.0 Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job not removed from queue.jobs after calling queue.removeJob(id)

4 participants