Fix unsafe handling of DateFormatter#6
Merged
jordanebelanger merged 1 commit intobrainfinance:masterfrom Apr 24, 2024
Merged
Conversation
because DateFormatter is not thread safe on Linux
Collaborator
|
@sidepelican Are you having an actual problem with this? I've been running this on linux for years without ever incurring an issue related to this. |
Contributor
Author
|
Yes, I have encountered this in another case, not in this library, but in the same usage. It's easy to reproduce the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateFormatter is not thread safe on Linux.
swiftlang/swift-corelibs-foundation#3166
It is better to use thread-local to reduce initialization costs while handling safely.