Modernize and remove factory#8
Merged
jordanebelanger merged 13 commits intobrainfinance:masterfrom Apr 24, 2024
Merged
Conversation
because DateFormatter is not thread safe on Linux
Package.swift
Outdated
| @@ -1,22 +1,33 @@ | |||
| // swift-tools-version:5.1 | |||
| // swift-tools-version:5.9 | |||
Collaborator
There was a problem hiding this comment.
Is this the lowest we can go?
Contributor
Author
There was a problem hiding this comment.
Sorry, this was just my feelings.
The actual minimum Swift version is 5.8." (by swift-nio)
jordanebelanger
approved these changes
Apr 24, 2024
Collaborator
|
@sidepelican superb thank you very much 👍 Will do a new major version 4.0.0 with these new changes. |
Collaborator
|
@sidepelican If you are willing, we need to update the README with updated logger initialization examples. |
Contributor
Author
|
Removed Bootstrapping section and fixed example code. |
Collaborator
|
@sidepelican let me know when ready |
Contributor
Author
|
@jordanebelanger If there are no other issues to address, I am ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the implementation overall.
Changes
EventLoopGroupunnecessary and switch the worker queue toNIOThreadPool.(It might appear that the file I/O has become blocking, but it is the same as
NonBlockingFileIO.)NonBlockingFileIOis a bit outdated.NIOFileSystemin swift-nio also seems good, but it is not stable yet.StackdriverLogHandler.Factory, as there is no need for setup due to the default singletonNIOThreadPool.NIOThreadPool.This PR including #7 and #6 .