Skip to content

remove all armv7 references#3

Merged
christopherfujino merged 1 commit intochristopherfujino:masterfrom
XilaiZhang:patch-1
Sep 17, 2022
Merged

remove all armv7 references#3
christopherfujino merged 1 commit intochristopherfujino:masterfrom
XilaiZhang:patch-1

Conversation

@XilaiZhang
Copy link
Copy Markdown
Collaborator

@XilaiZhang XilaiZhang commented Sep 17, 2022

align master branch with the script used in current release. fixes flutter/flutter#111764

Copy link
Copy Markdown
Owner

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino christopherfujino merged commit 066b00c into christopherfujino:master Sep 17, 2022
Comment thread codesign.py
],
},
'Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
'Flutter.xcframework/ios-arm64_armv7/Flutter.framework/Flutter',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't removed, it was renamed to Flutter.xcframework/ios-arm64/Flutter.framework/Flutter.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XilaiZhang is this what we're running in production?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case, we should fix this repo, and then pull it onto the codesigning bot

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Umm that’s interesting, I wonder if we have missed this artifact in release the entire time

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the potential delay but I will take a look later. I headed out when Christopher started online chess

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out! added paths for ios, ios-release and ios-profile, PR at #4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we have missed this artifact in release the entire time

It was renamed from ios-arm64_armv7 to ios-arm64. See flutter/flutter#102012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impellerc should be codesigned for macOS

3 participants