update file paths in ios artifacts#4
Merged
XilaiZhang merged 2 commits intochristopherfujino:masterfrom Feb 4, 2023
Merged
Conversation
Collaborator
Author
|
Would be great if @christopherfujino can review this PR and use it for beta release this week |
jmagman
approved these changes
Sep 19, 2022
Contributor
jmagman
left a comment
There was a problem hiding this comment.
See flutter/flutter#102012 where the conductor codesign script was updated. I'm not sure what this codesign.py repo is still used for, does this need to stay in sync with that file?
Collaborator
Author
Yeah it is quite unintuitive. we are currently using codesign.py to sign the release artifacts. |
Collaborator
Author
|
Will merge in this now to work with flutter/flutter#111764 together |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I verified that we omitted these files previously. Thanks Christopher and Jenn for pointing this out!