fix(issue list): reject pull request-only search qualifiers by LouisLau-art · Pull Request #12623 · cli/cli

LouisLau-art · 2026-02-06T02:45:58Z

Summary

Detect pull-request-only qualifiers in gh issue list --search (is:pr, type:pr, and pull-request variants).
Return a clear error message instead of issuing a GraphQL issue search that yields empty nodes.
Keep normal issue search behavior unchanged.

Why

gh issue list -S 'is:pr' currently produces blank rows because the search query mixes issue and PR semantics, and the response nodes don't match the expected issue shape.

This change fails fast with guidance to use gh pr list for PR searches.

Test

Added TestSearchIssues_rejectsPullRequestQualifiers in pkg/cmd/issue/list/http_test.go.
go test ./pkg/cmd/issue/list

github-actions · 2026-02-06T02:46:12Z

Thank you for your pull request! 🎉

This PR appears to fix the following issues that are not labeled with help wanted Contributions welcome :

gh issue list -S 'is:pr' returns blank issues #8272

As outlined in our Contributing Guidelines, we expect that PRs are only created for issues that have been labeled help wanted.

While we appreciate your initiative, please note that:

PRs for non-help wanted issues may not be reviewed immediately as they might not align with our current priorities
The issue might already be assigned to a team member or planned for a specific release
We may need to close this PR. For example, if it conflicts with ongoing work or architectural decisions

What happens next:

Our team will review this PR and the associated issues
We may add the help wanted label to the issues, if appropriate, and review this pull request
In some cases, we may need to close the PR. For example, if it doesn't fit our current roadmap

Thank you for your understanding and contribution to the project! 🙏

This comment was automatically generated by cliAutomation.

BagToad

Approach looks good! I'm happy to deal with this by formalizing the requirement to use gh pr list --search for searching PRs, which is the approach you've taken here.

One thing before we can merge: the test only covers is:pr, but the regex also matches type:pr, type:pull-request, and case-insensitive variants. Could you add test cases for those patterns too, please?

💭 Thought: maybe we should see if gh pr list --search needs the same fix?

LouisLau-art · 2026-03-03T02:10:13Z

Thanks for the clear guidance — that makes sense.

I’ll add coverage for the other matched variants as requested:

type:pr
type:pull-request
case-insensitive forms

And I’ll also check whether gh pr list --search needs the same guard.

I’ll push the follow-up shortly.

LouisLau-art · 2026-03-03T02:14:03Z

Follow-up pushed in b601b307a.

I expanded TestSearchIssues_rejectsPullRequestQualifiers to cover the requested variants:

type:pr
type:pull-request
type:pullrequest
case-insensitive variants (is:PR, TYPE:Pull-Request)

The test still asserts we fail fast before any network call (assert.Len(reg.Requests, 0)).

I also checked gh pr list --search: it already routes through the PR search path and intentionally builds queries with type:pr, so this issue-list guard does not need to be mirrored there.

LouisLau-art · 2026-03-03T08:04:56Z

Follow-up tests for type:pr, type:pull-request, and case-insensitive variants are in the branch and the full PR checks are green.

Could you please re-review when convenient?

BagToad

Test coverage looks great, thanks for the quick turnaround and for turning it into a table test.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.87.3` → `v2.88.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.88.1`](https://github.com/cli/cli/releases/tag/v2.88.1): GitHub CLI 2.88.1 [Compare Source](cli/cli@v2.88.0...v2.88.1) #### Fix `pr` commands failing with `read:project` scope error v2.88.0 introduced a regression where `pr` commands would fail with the error: ``` error: your authentication token is missing required scopes [read:project] To request it, run: gh auth refresh -s read:project ``` Previously, missing read:project scope was gracefully handled, and project data was silently skipped. A change inadvertently broke the error matching that enabled this graceful degradation. v2.88.1 reverts these changes so that `pr` commands work correctly without requiring the `read:project` scope. #### What's Changed - Migrate Windows code signing from client secret to OIDC by [@BagToad](https://github.com/BagToad) in [#12911](cli/cli#12911) - Revert "refactor: deduplicate scope error handling between api/client.go and project queries" by [@williammartin](https://github.com/williammartin) in [#12914](cli/cli#12914) - Revert "fix: clarify scope error while creating issues for projects" by [@williammartin](https://github.com/williammartin) in [#12915](cli/cli#12915) **Full Changelog**: <cli/cli@v2.88.0...v2.88.1> ### [`v2.88.0`](https://github.com/cli/cli/releases/tag/v2.88.0): GitHub CLI 2.88.0 [Compare Source](cli/cli@v2.87.3...v2.88.0) ####

Request Copilot Code Review from `gh` <img width="80%" height="80%" alt="image" src="proxy.php?url=https%3A%2F%2Fgithub.com%2F%3Ca+href%3D"https://github.com/user-attachments/assets/c9b86700-5934-44b6-9210-227495a18d8e">https://github.com/user-attachments/assets/c9b86700-5934-44b6-9210-227495a18d8e" /> `gh pr create` and `gh pr edit` now support [Copilot Code Review](https://docs.github.com/en/copilot/using-github-copilot/code-review/using-copilot-code-review) as a reviewer. Request a review with `--add-reviewer @copilot`, or select Copilot interactively from the searchable reviewer prompt. Create a pull request and request review from Copilot: ``` gh pr create --reviewer @copilot ``` Edit a pull request and request review from Copilot: ``` gh pr edit --add-reviewer @copilot ``` #### Close issues as duplicates with `gh issue close --duplicate-of` You can now close issues as duplicates and link to a duplicate issue directly from the CLI. The new `--duplicate-of` flag accepts an issue number or URL and marks the closed issue as a duplicate of the referenced one. You can also use `--reason duplicate` to set the close reason without linking a specific issue. ``` # Close as duplicate, linking to the original issue gh issue close 123 --duplicate-of 456 # Close with duplicate reason only gh issue close 123 --reason duplicate ``` #### JSON support for `gh agent-task` `gh agent-task list` and `gh agent-task view` now support `--json`, `--jq`, and `--template` flags, consistent with other `gh` commands. ``` gh agent-task list --json id,name,state gh agent-task view <id> --json state --jq '.state' ``` #### What's Changed ##### ✨ Features - `gh pr create`: login-based reviewer requests and search-based interactive selection by [@BagToad](https://github.com/BagToad) in [#12627](cli/cli#12627) - `gh pr view` and `gh issue view`: show friendly display names for all actors by [@BagToad](https://github.com/BagToad) in [#12854](cli/cli#12854) - `gh issue close`: add `--duplicate-of` flag and duplicate reason by [@tksohishi](https://github.com/tksohishi) in [#12811](cli/cli#12811) - `gh pr diff`: add `--exclude` flag to filter files from diff output by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12655](cli/cli#12655) - `gh pr view/list`: add `changeType` field to files JSON output by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12657](cli/cli#12657) - `gh repo clone`: add `--no-upstream` flag by [@4RH1T3CT0R7](https://github.com/4RH1T3CT0R7) in [#12686](cli/cli#12686) - `gh repo edit`: add `--squash-merge-commit-message` flag by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12846](cli/cli#12846) - `gh browse`: add `--blame` flag by [@masonmcelvain](https://github.com/masonmcelvain) in [#11486](cli/cli#11486) - `gh agent-task list`: add `--json` support by [@maxbeizer](https://github.com/maxbeizer) in [#12806](cli/cli#12806) - `gh agent-task view`: add `--json` support by [@maxbeizer](https://github.com/maxbeizer) in [#12807](cli/cli#12807) - `gh copilot`: set `COPILOT_GH` env var when launching Copilot CLI by [@devm33](https://github.com/devm33) in [#12821](cli/cli#12821) ##### 🐛 Fixes - Fix `gh project item-edit` error when editing Draft Issue with only one (`--title`/`--body`) flag by [@ManManavadaria](https://github.com/ManManavadaria) in [#12787](cli/cli#12787) - Fix extension install error message showing raw struct instead of `owner/repo` by [@Copilot](https://github.com/Copilot) in [#12836](cli/cli#12836) - Fix incorrect integer conversion from int to uint16 in port forwarder by [@BagToad](https://github.com/BagToad) in [#12831](cli/cli#12831) - Fix invalid ANSI SGR escape code in JSON and diff colorization by [@BagToad](https://github.com/BagToad) in [#12720](cli/cli#12720) - Fix assignees `databaseId` always being `0` in `--json` output by [@srt32](https://github.com/srt32) in [#12783](cli/cli#12783) - Fix error when `--remote` flag used with repo argument by [@majiayu000](https://github.com/majiayu000) in [#12375](cli/cli#12375) - Fix redundant API call in `gh issue view --comments` by [@VishnuVV27](https://github.com/VishnuVV27) in [#12652](cli/cli#12652) - Clarify scope error while creating issues for projects by [@elijahthis](https://github.com/elijahthis) in [#12596](cli/cli#12596) - Reject pull request-only search qualifiers in `gh issue list` by [@LouisLau-art](https://github.com/LouisLau-art) in [#12623](cli/cli#12623) - Prevent `.git/config` corruption on repeated `issue develop --name` invocation by [@gunadhya](https://github.com/gunadhya) in [#12651](cli/cli#12651) - Use pre-compiled regexp for matching Content-Type by [@itchyny](https://github.com/itchyny) in [#12781](cli/cli#12781) - Isolate generated licenses per platform (os/arch) by [@babakks](https://github.com/babakks) in [#12774](cli/cli#12774) ##### 📚 Docs & Chores - Add examples to `gh issue close` help text by [@BagToad](https://github.com/BagToad) in [#12830](cli/cli#12830) - Customizable install `prefix` in Makefile by [@scarf005](https://github.com/scarf005) in [#11714](cli/cli#11714) - Deduplicate scope error handling between `api/client.go` and project queries by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12845](cli/cli#12845) - Remove unnecessary `StateReason` and `StateReasonDuplicate` feature detection by [@BagToad](https://github.com/BagToad) in [#12838](cli/cli#12838) - Update Go version requirement to 1.26+ by [@BagToad](https://github.com/BagToad) in [#12864](cli/cli#12864) - Add monthly pitch surfacing workflow by [@tidy-dev](https://github.com/tidy-dev) in [#12894](cli/cli#12894) #####

Dependencies - Bump Go from 1.25.7 to 1.26.1 by [@BagToad](https://github.com/BagToad) in [#12860](cli/cli#12860) - chore(deps): bump golang.org/x/sync from 0.19.0 to 0.20.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12886](cli/cli#12886) - chore(deps): bump google.golang.org/grpc from 1.79.1 to 1.79.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#12851](cli/cli#12851) - chore(deps): bump github.com/docker/cli from 29.0.3+incompatible to 29.2.0+incompatible by [@dependabot](https://github.com/dependabot)\[bot] in [#12842](cli/cli#12842) - chore(deps): bump google.golang.org/grpc from 1.78.0 to 1.79.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#12759](cli/cli#12759) - chore(deps): bump goreleaser/goreleaser-action from 6.4.0 to 7.0.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12760](cli/cli#12760) - chore(deps): bump actions/upload-artifact from 6 to 7 by [@dependabot](https://github.com/dependabot)\[bot] in [#12797](cli/cli#12797) - chore(deps): bump actions/download-artifact from 7 to 8 by [@dependabot](https://github.com/dependabot)\[bot] in [#12796](cli/cli#12796) - chore(deps): bump actions/attest-build-provenance from 3.2.0 to 4.1.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12795](cli/cli#12795) - chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.11 to 1.4.13 by [@dependabot](https://github.com/dependabot)\[bot] in [#12615](cli/cli#12615) #### New Contributors - [@srt32](https://github.com/srt32) made their first contribution in [#12783](cli/cli#12783) - [@itchyny](https://github.com/itchyny) made their first contribution in [#12781](cli/cli#12781) - [@VishnuVV27](https://github.com/VishnuVV27) made their first contribution in [#12652](cli/cli#12652) - [@elijahthis](https://github.com/elijahthis) made their first contribution in [#12596](cli/cli#12596) - [@ManManavadaria](https://github.com/ManManavadaria) made their first contribution in [#12787](cli/cli#12787) - [@maxbeizer](https://github.com/maxbeizer) made their first contribution in [#12806](cli/cli#12806) - [@LouisLau-art](https://github.com/LouisLau-art) made their first contribution in [#12623](cli/cli#12623) - [@4RH1T3CT0R7](https://github.com/4RH1T3CT0R7) made their first contribution in [#12686](cli/cli#12686) - [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) made their first contribution in [#12657](cli/cli#12657) - [@masonmcelvain](https://github.com/masonmcelvain) made their first contribution in [#11486](cli/cli#11486) - [@scarf005](https://github.com/scarf005) made their first contribution in [#11714](cli/cli#11714) - [@tksohishi](https://github.com/tksohishi) made their first contribution in [#12811](cli/cli#12811) - [@tidy-dev](https://github.com/tidy-dev) made their first contribution in [#12894](cli/cli#12894) **Full Changelog**: <cli/cli@v2.87.3...v2.88.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

LouisLau-art requested a review from a team as a code owner February 6, 2026 02:45

LouisLau-art requested a review from BagToad February 6, 2026 02:45

LouisLau-art temporarily deployed to cli-automation February 6, 2026 02:46 — with GitHub Actions Inactive

cliAutomation added the external pull request originating outside of the CLI core team label Feb 6, 2026

LouisLau-art mentioned this pull request Feb 6, 2026

gh issue list -S 'is:pr' returns blank issues #8272

Closed

fix(issue list): reject pull request-only search qualifiers

5194256

BagToad force-pushed the fix/issue-list-pr-search-qualifier branch from a1802dc to 5194256 Compare March 2, 2026 17:50

BagToad requested changes Mar 2, 2026

View reviewed changes

test(issue list): cover additional PR search qualifier variants

b601b30

BagToad approved these changes Mar 3, 2026

View reviewed changes

BagToad merged commit d983ae0 into cli:trunk Mar 3, 2026
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(issue list): reject pull request-only search qualifiers#12623

fix(issue list): reject pull request-only search qualifiers#12623
BagToad merged 2 commits intocli:trunkfrom
LouisLau-art:fix/issue-list-pr-search-qualifier

LouisLau-art commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

BagToad left a comment •

edited

Loading

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

BagToad left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

LouisLau-art commented Feb 6, 2026

Summary

Why

Test

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

BagToad left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

LouisLau-art commented Mar 3, 2026

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BagToad left a comment •

edited

Loading