Add `--duplicate-of` flag and duplicate reason to issue close by tksohishi · Pull Request #12811 · cli/cli

tksohishi · 2026-03-01T01:03:52Z

Summary

Add --reason duplicate option and --duplicate-of <issue> flag to gh issue close
--duplicate-of accepts an issue number or URL, validates it references a different issue (not a PR), and passes the duplicate issue ID to the closeIssue mutation
Feature detection checks whether the GHES instance supports the DUPLICATE enum value in IssueClosedStateReason before using it

Test plan

Unit tests for new flag parsing (--reason duplicate, --duplicate-of, conflicting flags)
Unit tests for close behavior (duplicate reason, duplicate-of resolution, self-reference guard, PR guard, unsupported GHES fallback)
Feature detection tests for StateReasonDuplicate on github.com, ghe.com, and GHES with/without the enum value

Support closing issues as duplicates via --reason duplicate and --duplicate-of <issue> flags. The --duplicate-of flag accepts an issue number or URL, validates it references a different issue (not a PR), and passes the duplicate issue ID to the closeIssue mutation. Feature detection checks whether the GHES instance supports the DUPLICATE enum value in IssueClosedStateReason before using it.

BagToad

Nice work; thorough feature detection, good edge case handling, and solid test coverage. Also appreciate you doing the GHES feature detection; most folks miss that.

Requested change: The new IssueClosedStateReason_enumValues introspection query adds a second API round-trip in IssueFeatures(). Could you combine it with the existing Issue_fields query? Something like:

var featureDetection struct {
    Issue struct {
        Fields []struct {
            Name string
        } `graphql:"fields(includeDeprecated: true)"`
    } `graphql:"Issue: __type(name: \"Issue\")"`
    IssueClosedStateReason struct {
        EnumValues []struct {
            Name string
        } `graphql:"enumValues(includeDeprecated: true)"`
    } `graphql:"IssueClosedStateReason: __type(name: \"IssueClosedStateReason\")"`
}

If we can check both results in one place without the extra call, I think that'd be ideal. Let me know if this is a pain though.

Minor note (non-blocking): The --duplicate-of + --reason conflict check runs in both NewCmdClose and closeRun. The latter is redundant when called from cobra, but I don't mind it being duplicated.

Merge the Issue_fields and IssueClosedStateReason_enumValues introspection queries into one call to avoid an extra API round-trip on GHES.

tksohishi · 2026-03-04T03:04:45Z

Thank you for the review, @BagToad! I've combined the two introspection queries into a single GraphQL call as requested.

BagToad

Tested locally on a real repo, all edge cases work. Thanks for the quick turnaround on the combined query.

williammartin · 2026-03-04T11:49:41Z

Do we need the GHES check here? I think the DUPLICATE enum variant was added in 3.16 which is older than our earliest supported version:

BagToad · 2026-03-04T16:41:49Z

Do we need the GHES check here? I think the DUPLICATE enum variant was added in 3.16 which is older than our earliest supported version:
* https://docs.github.com/en/[email protected]/graphql/reference/enums?versionId=free-pro-team%40latest&productId=graphql#issueclosedstatereason

* https://docs.github.com/en/[email protected]/graphql/reference/enums?versionId=free-pro-team%40latest&productId=graphql#issueclosedstatereason

Good catch, I don't think we need it. I'll do a follow-up PR.

The DUPLICATE enum variant for IssueClosedStateReason was added in GHES 3.16, which is older than the earliest supported GHES version. The feature detection check is therefore unnecessary. Addresses: #12811 (comment) Co-authored-by: Copilot <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.87.3` → `v2.88.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.88.1`](https://github.com/cli/cli/releases/tag/v2.88.1): GitHub CLI 2.88.1 [Compare Source](cli/cli@v2.88.0...v2.88.1) #### Fix `pr` commands failing with `read:project` scope error v2.88.0 introduced a regression where `pr` commands would fail with the error: ``` error: your authentication token is missing required scopes [read:project] To request it, run: gh auth refresh -s read:project ``` Previously, missing read:project scope was gracefully handled, and project data was silently skipped. A change inadvertently broke the error matching that enabled this graceful degradation. v2.88.1 reverts these changes so that `pr` commands work correctly without requiring the `read:project` scope. #### What's Changed - Migrate Windows code signing from client secret to OIDC by [@BagToad](https://github.com/BagToad) in [#12911](cli/cli#12911) - Revert "refactor: deduplicate scope error handling between api/client.go and project queries" by [@williammartin](https://github.com/williammartin) in [#12914](cli/cli#12914) - Revert "fix: clarify scope error while creating issues for projects" by [@williammartin](https://github.com/williammartin) in [#12915](cli/cli#12915) **Full Changelog**: <cli/cli@v2.88.0...v2.88.1> ### [`v2.88.0`](https://github.com/cli/cli/releases/tag/v2.88.0): GitHub CLI 2.88.0 [Compare Source](cli/cli@v2.87.3...v2.88.0) ####

Request Copilot Code Review from `gh` <img width="80%" height="80%" alt="image" src="proxy.php?url=https%3A%2F%2Fgithub.com%2F%3Ca+href%3D"https://github.com/user-attachments/assets/c9b86700-5934-44b6-9210-227495a18d8e">https://github.com/user-attachments/assets/c9b86700-5934-44b6-9210-227495a18d8e" /> `gh pr create` and `gh pr edit` now support [Copilot Code Review](https://docs.github.com/en/copilot/using-github-copilot/code-review/using-copilot-code-review) as a reviewer. Request a review with `--add-reviewer @copilot`, or select Copilot interactively from the searchable reviewer prompt. Create a pull request and request review from Copilot: ``` gh pr create --reviewer @copilot ``` Edit a pull request and request review from Copilot: ``` gh pr edit --add-reviewer @copilot ``` #### Close issues as duplicates with `gh issue close --duplicate-of` You can now close issues as duplicates and link to a duplicate issue directly from the CLI. The new `--duplicate-of` flag accepts an issue number or URL and marks the closed issue as a duplicate of the referenced one. You can also use `--reason duplicate` to set the close reason without linking a specific issue. ``` # Close as duplicate, linking to the original issue gh issue close 123 --duplicate-of 456 # Close with duplicate reason only gh issue close 123 --reason duplicate ``` #### JSON support for `gh agent-task` `gh agent-task list` and `gh agent-task view` now support `--json`, `--jq`, and `--template` flags, consistent with other `gh` commands. ``` gh agent-task list --json id,name,state gh agent-task view <id> --json state --jq '.state' ``` #### What's Changed ##### ✨ Features - `gh pr create`: login-based reviewer requests and search-based interactive selection by [@BagToad](https://github.com/BagToad) in [#12627](cli/cli#12627) - `gh pr view` and `gh issue view`: show friendly display names for all actors by [@BagToad](https://github.com/BagToad) in [#12854](cli/cli#12854) - `gh issue close`: add `--duplicate-of` flag and duplicate reason by [@tksohishi](https://github.com/tksohishi) in [#12811](cli/cli#12811) - `gh pr diff`: add `--exclude` flag to filter files from diff output by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12655](cli/cli#12655) - `gh pr view/list`: add `changeType` field to files JSON output by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12657](cli/cli#12657) - `gh repo clone`: add `--no-upstream` flag by [@4RH1T3CT0R7](https://github.com/4RH1T3CT0R7) in [#12686](cli/cli#12686) - `gh repo edit`: add `--squash-merge-commit-message` flag by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12846](cli/cli#12846) - `gh browse`: add `--blame` flag by [@masonmcelvain](https://github.com/masonmcelvain) in [#11486](cli/cli#11486) - `gh agent-task list`: add `--json` support by [@maxbeizer](https://github.com/maxbeizer) in [#12806](cli/cli#12806) - `gh agent-task view`: add `--json` support by [@maxbeizer](https://github.com/maxbeizer) in [#12807](cli/cli#12807) - `gh copilot`: set `COPILOT_GH` env var when launching Copilot CLI by [@devm33](https://github.com/devm33) in [#12821](cli/cli#12821) ##### 🐛 Fixes - Fix `gh project item-edit` error when editing Draft Issue with only one (`--title`/`--body`) flag by [@ManManavadaria](https://github.com/ManManavadaria) in [#12787](cli/cli#12787) - Fix extension install error message showing raw struct instead of `owner/repo` by [@Copilot](https://github.com/Copilot) in [#12836](cli/cli#12836) - Fix incorrect integer conversion from int to uint16 in port forwarder by [@BagToad](https://github.com/BagToad) in [#12831](cli/cli#12831) - Fix invalid ANSI SGR escape code in JSON and diff colorization by [@BagToad](https://github.com/BagToad) in [#12720](cli/cli#12720) - Fix assignees `databaseId` always being `0` in `--json` output by [@srt32](https://github.com/srt32) in [#12783](cli/cli#12783) - Fix error when `--remote` flag used with repo argument by [@majiayu000](https://github.com/majiayu000) in [#12375](cli/cli#12375) - Fix redundant API call in `gh issue view --comments` by [@VishnuVV27](https://github.com/VishnuVV27) in [#12652](cli/cli#12652) - Clarify scope error while creating issues for projects by [@elijahthis](https://github.com/elijahthis) in [#12596](cli/cli#12596) - Reject pull request-only search qualifiers in `gh issue list` by [@LouisLau-art](https://github.com/LouisLau-art) in [#12623](cli/cli#12623) - Prevent `.git/config` corruption on repeated `issue develop --name` invocation by [@gunadhya](https://github.com/gunadhya) in [#12651](cli/cli#12651) - Use pre-compiled regexp for matching Content-Type by [@itchyny](https://github.com/itchyny) in [#12781](cli/cli#12781) - Isolate generated licenses per platform (os/arch) by [@babakks](https://github.com/babakks) in [#12774](cli/cli#12774) ##### 📚 Docs & Chores - Add examples to `gh issue close` help text by [@BagToad](https://github.com/BagToad) in [#12830](cli/cli#12830) - Customizable install `prefix` in Makefile by [@scarf005](https://github.com/scarf005) in [#11714](cli/cli#11714) - Deduplicate scope error handling between `api/client.go` and project queries by [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) in [#12845](cli/cli#12845) - Remove unnecessary `StateReason` and `StateReasonDuplicate` feature detection by [@BagToad](https://github.com/BagToad) in [#12838](cli/cli#12838) - Update Go version requirement to 1.26+ by [@BagToad](https://github.com/BagToad) in [#12864](cli/cli#12864) - Add monthly pitch surfacing workflow by [@tidy-dev](https://github.com/tidy-dev) in [#12894](cli/cli#12894) #####

Dependencies - Bump Go from 1.25.7 to 1.26.1 by [@BagToad](https://github.com/BagToad) in [#12860](cli/cli#12860) - chore(deps): bump golang.org/x/sync from 0.19.0 to 0.20.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12886](cli/cli#12886) - chore(deps): bump google.golang.org/grpc from 1.79.1 to 1.79.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#12851](cli/cli#12851) - chore(deps): bump github.com/docker/cli from 29.0.3+incompatible to 29.2.0+incompatible by [@dependabot](https://github.com/dependabot)\[bot] in [#12842](cli/cli#12842) - chore(deps): bump google.golang.org/grpc from 1.78.0 to 1.79.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#12759](cli/cli#12759) - chore(deps): bump goreleaser/goreleaser-action from 6.4.0 to 7.0.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12760](cli/cli#12760) - chore(deps): bump actions/upload-artifact from 6 to 7 by [@dependabot](https://github.com/dependabot)\[bot] in [#12797](cli/cli#12797) - chore(deps): bump actions/download-artifact from 7 to 8 by [@dependabot](https://github.com/dependabot)\[bot] in [#12796](cli/cli#12796) - chore(deps): bump actions/attest-build-provenance from 3.2.0 to 4.1.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12795](cli/cli#12795) - chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.11 to 1.4.13 by [@dependabot](https://github.com/dependabot)\[bot] in [#12615](cli/cli#12615) #### New Contributors - [@srt32](https://github.com/srt32) made their first contribution in [#12783](cli/cli#12783) - [@itchyny](https://github.com/itchyny) made their first contribution in [#12781](cli/cli#12781) - [@VishnuVV27](https://github.com/VishnuVV27) made their first contribution in [#12652](cli/cli#12652) - [@elijahthis](https://github.com/elijahthis) made their first contribution in [#12596](cli/cli#12596) - [@ManManavadaria](https://github.com/ManManavadaria) made their first contribution in [#12787](cli/cli#12787) - [@maxbeizer](https://github.com/maxbeizer) made their first contribution in [#12806](cli/cli#12806) - [@LouisLau-art](https://github.com/LouisLau-art) made their first contribution in [#12623](cli/cli#12623) - [@4RH1T3CT0R7](https://github.com/4RH1T3CT0R7) made their first contribution in [#12686](cli/cli#12686) - [@yuvrajangadsingh](https://github.com/yuvrajangadsingh) made their first contribution in [#12657](cli/cli#12657) - [@masonmcelvain](https://github.com/masonmcelvain) made their first contribution in [#11486](cli/cli#11486) - [@scarf005](https://github.com/scarf005) made their first contribution in [#11714](cli/cli#11714) - [@tksohishi](https://github.com/tksohishi) made their first contribution in [#12811](cli/cli#12811) - [@tidy-dev](https://github.com/tidy-dev) made their first contribution in [#12894](cli/cli#12894) **Full Changelog**: <cli/cli@v2.87.3...v2.88.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

tksohishi requested a review from a team as a code owner March 1, 2026 01:03

tksohishi requested a review from williammartin March 1, 2026 01:03

github-actions bot added external pull request originating outside of the CLI core team needs-triage needs to be reviewed labels Mar 1, 2026

tksohishi force-pushed the issue-close-duplicate-of branch from 07c8518 to 01c83ac Compare March 1, 2026 01:10

tksohishi mentioned this pull request Mar 1, 2026

issue close should support "closing as duplicate" #10786

Closed

BagToad requested changes Mar 3, 2026

View reviewed changes

BagToad changed the title ~~Add --duplicate-of flag and duplicate reason to issue close~~ Add --duplicate-of flag and duplicate reason to issue close Mar 3, 2026

BagToad changed the title ~~Add --duplicate-of flag and duplicate reason to issue close~~ Add --duplicate-of flag and duplicate reason to issue close Mar 3, 2026

tksohishi added 2 commits March 3, 2026 21:51

Combine issue feature detection into a single GraphQL query

2265820

Merge the Issue_fields and IssueClosedStateReason_enumValues introspection queries into one call to avoid an extra API round-trip on GHES.

Merge branch 'trunk' into issue-close-duplicate-of

b9c8d8e

BagToad approved these changes Mar 4, 2026

View reviewed changes

BagToad merged commit 3fec2e5 into cli:trunk Mar 4, 2026
11 checks passed

BagToad mentioned this pull request Mar 4, 2026

docs: add examples to gh issue close help text #12830

Merged

tksohishi deleted the issue-close-duplicate-of branch March 4, 2026 03:50

williammartin removed the needs-triage needs to be reviewed label Mar 4, 2026

BagToad mentioned this pull request Mar 4, 2026

Remove unnecessary StateReason and StateReasonDuplicate feature detection #12838

Merged

delight-ai-agent mentioned this pull request Mar 10, 2026

Support closing issues as duplicate of another issue delight-co/finest-grained-auth-proxy#63

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `--duplicate-of` flag and duplicate reason to issue close#12811

Add `--duplicate-of` flag and duplicate reason to issue close#12811
BagToad merged 3 commits intocli:trunkfrom
tksohishi:issue-close-duplicate-of

tksohishi commented Mar 1, 2026 •

edited

Loading

Uh oh!

BagToad left a comment

Uh oh!

tksohishi commented Mar 4, 2026

Uh oh!

BagToad left a comment

Uh oh!

Uh oh!

williammartin commented Mar 4, 2026

Uh oh!

BagToad commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tksohishi commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

tksohishi commented Mar 4, 2026

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

williammartin commented Mar 4, 2026

Uh oh!

BagToad commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tksohishi commented Mar 1, 2026 •

edited

Loading