Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: code-squad/javascript-polygon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: code-squad/javascript-polygon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: Soorealbutnice
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 3 files changed
  • 7 contributors

Commits on Nov 13, 2017

  1. Configuration menu
    Copy the full SHA
    9d32c1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df49a52 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. Configuration menu
    Copy the full SHA
    1aded7f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Configuration menu
    Copy the full SHA
    a65d294 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea3f230 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #5 from hannarita/hannarita

    Hannarita/다각형의 넓이 구하는 함수 만들기 완료
    crongro authored Nov 15, 2017
    Configuration menu
    Copy the full SHA
    4ca045a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. 1차 다각형넓이구하기 (#32)

    * 1차 다각형넓이구하기
    
    * 1.함수명 변경 2.숫자판별을 함수가 아닌 개별 함수내의 조건으로 재설정 3.let pi > const pi 4.return 오류 수정
    alisonjh authored and crongro committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    095706e View commit details
    Browse the repository at this point in the history
  2. Step2 (#34)

    * 다각형 넓이 (#29)
    
    * index of polygonSize
    
    * Full index of html and get area of circle, square, trapezoid, cylinder
    
    * restart
    
    * add sizeCircle function
    
    * add function sizeSquare, add testcode
    
    * add function sizeTrapezoid, add test code
    
    * add function sizeSylinder, add distinguish test code, add test code
    
    * modify by referring to feedback, add function getArea, add function printExecutionSequence
    
    * Revise var to const, Change variable name arr -> ExecutionSequenceArray, and Revise PrintExecutionSequence function(revise forEach method to use arrow function),
    
    * revise isNum function to use 'for' statement and add typenumberfunction for isNum function
    
    * modifiy function sizeCircle to CalcCircleWidth and change inner contents
    
    * Modify sizeSquare function to CalcRectWidth and change inner contents
    
    * Modify sizeTrapezoid function to calcTrapezoidWidth function and revise inner contents
    
    * Modify sizeSylinder functino to calcSylinderWidth function and revise inner context
    
    * Modify getArea function to check Number of arguments
    
    * Revise little bugs,(add return to calcSylinderWidth, change some upperCase to lowerCase
    HTMLhead authored and crongro committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    97ff01e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d51bb30 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. step2_1 다각형의 넓이 구현 (#52)

    1. 반지름을 입력받아 원의 넓이를 계산하는 함수
    2. 사각형의 넓이를 계산하는 함수
    3. 사다리꼴의 넓이를 계산하는 함수
    4. 원기둥의 넓이를 계산하는 함수
    위의 네 개의 함수를 구현하고 숫자가 아닌 경우, 인자의 갯수가 틀린 경우 에러를 반환합니다.
    soojinroh authored and crongro committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    afdf974 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. 코드리뷰에 따라 코드 수정

    1. Math.pow를 중복해서 호출 사용하던 것을 const{pow} = Math 로 비구조화할당하여 사용하는 것으로 수정하였습니다.
    2. 원기둥을 구하는 함수 cylinderArea()에서 원의 넓이를 구하는데 circleArea() 함수를 재사용하는 것으로 수정하였습니다.
    indiveloper committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    bcd7fa7 View commit details
    Browse the repository at this point in the history
  2. 코드리뷰에 따라 코드 수정 (#87)

    1. Math.pow를 중복해서 호출 사용하던 것을 const{pow} = Math 로 비구조화할당하여 사용하는 것으로 수정하였습니다.
    2. 원기둥을 구하는 함수 cylinderArea()에서 원의 넓이를 구하는데 circleArea() 함수를 재사용하는 것으로 수정하였습니다.
    soojinroh authored and crongro committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    753e474 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. 190411 JS Step 2-2 구현

    1.getArea()함수 구현
    2.printExecutionSequence() 함수 구현
    3.printExecutionSequence() 에서 함수의 결과까지 같이 출력하도록 수정
    indiveloper committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    15562af View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Merge pull request #93 from Soorealbutnice/step2-2

    Step2 2
    honux77 authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    4210f82 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Configuration menu
    Copy the full SHA
    5386748 View commit details
    Browse the repository at this point in the history
Loading