Skip to content

docs: clean up data types section#1412

Merged
samsja merged 3 commits intomainfrom
docs-clean-up-data-types
Apr 18, 2023
Merged

docs: clean up data types section#1412
samsja merged 3 commits intomainfrom
docs-clean-up-data-types

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

@anna-charlotte anna-charlotte commented Apr 18, 2023

Resolving the following issues mentioned by @alexcg1:

  • data_types/image/image/ - some local URLs need to be to class names, not HTML pages
  • data_types/image/audio/ - some local URLs need to be to class names, not HTML pages
  • data_types/image/video/ - some local URLs need to be to class names, not HTML pages

===> as for the local urls, I used those for ImageTensor, AudioTensor, AnyTensor etc. I linked to the corresponding docs typing section, because they don't show up correctly in the API reference section. Will leave it like this for now.

  • data_types/video/video/ - video file plays with audio - very distracting

===> fixed: muted loop autoplay

  • 3d - huge lumps of nasty code for rendering meshes. can we do iframes instead?

===> I am not getting this to work while extracting the iframes to a seperate file.
I tried putting the srcdoc content to a separate file (<!DOCTYPE html><html lang=&quot;en&quot;> .... ) and then load it in an iframe:

<iframe src="proxy.php?url=https%3A%2F%2Fgithub.com%2F..%2Fiframe_3d_mesh.html" width="100%" height="500px"></iframe>

but it would not be able to load it. @alexcg1 do you know how to solve this? Otherwise i'll leave it like this for now

Signed-off-by: anna-charlotte <[email protected]>
@anna-charlotte anna-charlotte requested a review from alexcg1 April 18, 2023 11:46
@anna-charlotte anna-charlotte marked this pull request as ready for review April 18, 2023 11:47
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-docs-clean-up-data-types--jina-docs.netlify.app 🎉

@samsja samsja merged commit 7092406 into main Apr 18, 2023
@samsja samsja deleted the docs-clean-up-data-types branch April 18, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants