Skip to content

fix: use pd.concat() instead df.append() in to_dataframe() to avoid warning #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 2 commits into from
Apr 28, 2023
Merged

fix: use pd.concat() instead df.append() in to_dataframe() to avoid warning #1478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e68f1bd
fix: use pd.concat instead df.append to avoid warning
Apr 28, 2023
673307e
fix: pd dataframe from dict
Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docarray/array/doc_list/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ def to_dataframe(self) -> 'pd.DataFrame':

for doc in self:
doc_dict = _dict_to_access_paths(doc.dict())
df = df.append(doc_dict, ignore_index=True)
doc_dict = {k: [v] for k, v in doc_dict.items()}
Copy link
Copy Markdown
Member

@JoanFM JoanFM Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do u need to convert them to list?

Copy link
Copy Markdown
Contributor Author

@anna-charlotte anna-charlotte Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd.DataFrame.from_dict() expects a dict with the column names as keys, and the values have to be a list, therefore I wrap the value with a list

Copy link
Copy Markdown
Contributor Author

@anna-charlotte anna-charlotte Apr 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this v[0] would correspond to the first row, v[1] to the second row and so on. In our case we only have v[0] since len(v) = 1

df = pd.concat([df, pd.DataFrame.from_dict(doc_dict)], ignore_index=True)

return df

Expand Down