Skip to content

fix: annlite offsetmapping#504

Merged
numb3r3 merged 1 commit intomainfrom
fix-annlite-relead
Aug 26, 2022
Merged

fix: annlite offsetmapping#504
numb3r3 merged 1 commit intomainfrom
fix-annlite-relead

Conversation

@numb3r3
Copy link
Copy Markdown
Contributor

@numb3r3 numb3r3 commented Aug 26, 2022

Goals:

    1. fix the offsetmapping in annlite, (in_memory=False)
    1. __del__ should be placed in getsetdel.py
    1. should close lmdb cursor in __del__ so that lmdb can be reused in another annlite instance
  • check and update documentation, if required. See guide

@numb3r3 numb3r3 force-pushed the fix-annlite-relead branch from 3517319 to 566c6bc Compare August 26, 2022 12:33
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2022

Codecov Report

Merging #504 (3517319) into main (be78867) will increase coverage by 1.18%.
The diff coverage is 100.00%.

❗ Current head 3517319 differs from pull request most recent head 566c6bc. Consider uploading reports for the commit 566c6bc to get more accurate results

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   85.34%   86.53%   +1.18%     
==========================================
  Files         134      134              
  Lines        6702     6704       +2     
==========================================
+ Hits         5720     5801      +81     
+ Misses        982      903      -79     
Flag Coverage Δ
docarray 86.53% <100.00%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/annlite/seqlike.py 92.30% <ø> (+8.97%) ⬆️
docarray/array/storage/annlite/getsetdel.py 100.00% <100.00%> (+2.77%) ⬆️
docarray/array/storage/annlite/helper.py 50.00% <100.00%> (ø)
docarray/array/storage/base/helper.py 89.74% <0.00%> (+2.56%) ⬆️
docarray/array/storage/elastic/getsetdel.py 100.00% <0.00%> (+3.38%) ⬆️
docarray/array/storage/weaviate/getsetdel.py 100.00% <0.00%> (+5.26%) ⬆️
docarray/array/storage/sqlite/getsetdel.py 100.00% <0.00%> (+7.14%) ⬆️
docarray/array/storage/base/getsetdel.py 91.21% <0.00%> (+9.45%) ⬆️
docarray/array/mixins/getitem.py 87.87% <0.00%> (+10.60%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@numb3r3 numb3r3 requested a review from samsja August 26, 2022 12:42
@samsja
Copy link
Copy Markdown
Member

samsja commented Aug 26, 2022

Will this PR be compatible with old annlite version ?

This to know if we have to pin the annlite version to the last one or if it is retro compatible

Copy link
Copy Markdown
Member

@alaeddine-13 alaeddine-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3
Copy link
Copy Markdown
Contributor Author

numb3r3 commented Aug 26, 2022

Will this PR be compatible with old annlite version ?

yes

@numb3r3 numb3r3 merged commit 7c91c7b into main Aug 26, 2022
@numb3r3 numb3r3 deleted the fix-annlite-relead branch August 26, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants