Skip to content

fix: annlite offsetmapping #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
numb3r3 merged 1 commit into from
Aug 26, 2022
Merged

fix: annlite offsetmapping #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docarray/array/storage/annlite/getsetdel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ def _set_docs_by_ids(self, ids, docs: Iterable['Document'], mismatch_ids: Dict):
def _del_docs_by_ids(self, ids):
self._annlite.delete(ids)

def __del__(self) -> None:
if not self._persist:
self._offset2ids.clear()
self._annlite.clear()

self._annlite.close()

super().__del__()

def _load_offset2ids(self):
self._offsetmapping = OffsetMapping(
data_path=self._config.data_path, in_memory=False
Expand Down
2 changes: 1 addition & 1 deletion docarray/array/storage/annlite/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(
data_path: Optional[Path] = None,
in_memory: bool = True,
):
super().__init__(name, data_path, in_memory)
super().__init__(name, data_path, in_memory=in_memory)
self.create_table()
self._size = None

Expand Down
5 changes: 0 additions & 5 deletions docarray/array/storage/annlite/seqlike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ def extend(self, values: Iterable['Document']) -> None:
def append(self, value: 'Document'):
self.extend([value])

def __del__(self) -> None:
if not self._persist:
self._offset2ids.clear()
self._annlite.clear()

def __eq__(self, other):
"""In annlite backend, data are considered as identical if configs point to the same database source"""
return (
Expand Down