Skip to content

test: add tests for filtering in elasticsearch#584

Merged
JoanFM merged 2 commits intomainfrom
elastic-search-filter
Oct 3, 2022
Merged

test: add tests for filtering in elasticsearch#584
JoanFM merged 2 commits intomainfrom
elastic-search-filter

Conversation

@JoanFM
Copy link
Copy Markdown
Member

@JoanFM JoanFM commented Oct 3, 2022

Goals:

Add test filtering in ES with match ES Query

@JoanFM JoanFM force-pushed the elastic-search-filter branch from 0c0dd38 to 8d25b40 Compare October 3, 2022 10:45
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2022

Codecov Report

Merging #584 (8ff24a4) into main (aa8d072) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   84.91%   84.94%   +0.02%     
==========================================
  Files         133      133              
  Lines        6708     6708              
==========================================
+ Hits         5696     5698       +2     
+ Misses       1012     1010       -2     
Flag Coverage Δ
docarray 84.94% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/find.py 88.65% <ø> (+1.03%) ⬆️
docarray/array/storage/elastic/find.py 91.37% <ø> (ø)
docarray/array/storage/elastic/backend.py 95.58% <100.00%> (ø)
docarray/array/storage/weaviate/find.py 84.81% <0.00%> (+1.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM marked this pull request as ready for review October 3, 2022 11:48
@JoanFM JoanFM merged commit 6e49f52 into main Oct 3, 2022
@JoanFM JoanFM deleted the elastic-search-filter branch October 3, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant