Skip to content

feat: update qdrant version to 0.10.1#589

Closed
JoanFM wants to merge 23 commits intofeat-upgrade-qdrant-clientfrom
feat-qdrant-version-2
Closed

feat: update qdrant version to 0.10.1#589
JoanFM wants to merge 23 commits intofeat-upgrade-qdrant-clientfrom
feat-qdrant-version-2

Conversation

@JoanFM
Copy link
Copy Markdown
Member

@JoanFM JoanFM commented Oct 5, 2022 •
edited by AnneYang720
Loading

Goals:

  • update qdrant version to 0.10.1
  • update some of the tests (add grpc tests for qdrant)
  • update docs

alaeddine-13
alaeddine-13 reviewed Oct 5, 2022
View reviewed changes
@JoanFM JoanFM force-pushed the feat-qdrant-version-2 branch from 135bc14 to 0d066e0 Compare October 5, 2022 14:45
alaeddine-13
alaeddine-13 reviewed Oct 5, 2022
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Merging #589 (dd3b723) into feat-upgrade-qdrant-client (1731fc0) will decrease coverage by 31.29%.
The diff coverage is 0.00%.

❗ Current head dd3b723 differs from pull request most recent head 59f9893. Consider uploading reports for the commit 59f9893 to get more accurate results

@@                       Coverage Diff                       @@
##           feat-upgrade-qdrant-client     #589       +/-   ##
===============================================================
- Coverage                       88.23%   56.93%   -31.30%     
===============================================================
  Files                             133      133               
  Lines                            6585     6593        +8     
===============================================================
- Hits                             5810     3754     -2056     
- Misses                            775     2839     +2064
Flag Coverage Δ
docarray 56.93% <0.00%> (-31.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/qdrant/backend.py 0.00% <0.00%> (-96.12%) ⬇️
docarray/array/storage/qdrant/find.py 0.00% <ø> (-92.16%) ⬇️
docarray/array/storage/qdrant/getsetdel.py 0.00% <0.00%> (-81.95%) ⬇️
docarray/array/storage/qdrant/seqlike.py 0.00% <0.00%> (-85.72%) ⬇️
docarray/array/redis.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/qdrant.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/annlite.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/queryset/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/storage/annlite/find.py 0.00% <0.00%> (-100.00%) ⬇️
docarray/array/storage/qdrant/helper.py 0.00% <0.00%> (-100.00%) ⬇️
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM force-pushed the feat-upgrade-qdrant-client branch from 33b8d92 to 2a3b74d Compare October 5, 2022 15:25
@JoanFM JoanFM closed this Oct 5, 2022
@JoanFM JoanFM reopened this Oct 5, 2022
@JoanFM JoanFM force-pushed the feat-upgrade-qdrant-client branch from 1fa4772 to e91a9ee Compare October 7, 2022 08:53
@AnneYang720 AnneYang720 marked this pull request as ready for review November 4, 2022 02:40
@github-actions github-actions bot added size/xl and removed size/m labels Nov 4, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 6, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat-upgrade-qdrant-client@1ee6077). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@                      Coverage Diff                      @@
##             feat-upgrade-qdrant-client     #589   +/-   ##
=============================================================
  Coverage                              ?   87.83%           
=============================================================
  Files                                 ?      133           
  Lines                                 ?     6593           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     5791           
  Misses                                ?      802           
  Partials                              ?        0
Flag Coverage Δ
docarray 87.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

alaeddine-13
alaeddine-13 reviewed Nov 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alaeddine-13 alaeddine-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some grpc tests for qdrant ? just add an extra case to some of the existing tests, instead of just

        (DocumentArrayQdrant, QdrantConfig(n_dim=128)),

we do:

        (DocumentArrayQdrant, QdrantConfig(n_dim=128)),
        (DocumentArrayQdrant, QdrantConfig(n_dim=128, prefer_grpc=True)),

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 7, 2022

📝 Docs are deployed on https://ft-feat-qdrant-version-2--jina-docs.netlify.app 🎉

@AnneYang720 AnneYang720 marked this pull request as ready for review November 7, 2022 11:30
@JoanFM
Copy link
Copy Markdown
Member Author

JoanFM commented Nov 7, 2022

Please @AnneYang720 reopen this PR under ur name

@JoanFM JoanFM closed this Nov 7, 2022
@AnneYang720 AnneYang720 mentioned this pull request Nov 7, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaeddine-13 alaeddine-13 alaeddine-13 left review comments

Assignees

No one assigned

Labels

area/cicd area/core area/docs area/housekeeping area/setup area/testing component/array size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoanFM @codecov-commenter @alaeddine-13 @AnneYang720 @samsja