Skip to content

feat(qdrant): pass search_params in find#675

Merged
JoanFM merged 14 commits intomainfrom
feat_qdrant_search_params
Oct 26, 2022
Merged

feat(qdrant): pass search_params in find#675
JoanFM merged 14 commits intomainfrom
feat_qdrant_search_params

Conversation

@AnneYang720
Copy link
Copy Markdown
Contributor

@AnneYang720 AnneYang720 commented Oct 25, 2022

Goals:
This PR is related to issue #666
Change PR #668 to jina branch.

  • update code
  • add test
  • update documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2022

Codecov Report

Merging #675 (00f9e12) into main (4c90f4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         133      133           
  Lines        6541     6542    +1     
=======================================
+ Hits         5789     5790    +1     
  Misses        752      752           
Flag Coverage Δ
docarray 88.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/qdrant/find.py 92.15% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM requested a review from NicholasDunham October 25, 2022 13:22
Copy link
Copy Markdown
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait until @NicholasDunham approval

@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat_qdrant_search_params--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 33ed48f into main Oct 26, 2022
@JoanFM JoanFM deleted the feat_qdrant_search_params branch October 26, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants