feat(qdrant): pass search_params in find#668
Closed
AnneYang720 wants to merge 9 commits intodocarray:mainfrom
Closed
feat(qdrant): pass search_params in find#668AnneYang720 wants to merge 9 commits intodocarray:mainfrom
AnneYang720 wants to merge 9 commits intodocarray:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
===========================================
- Coverage 88.48% 78.40% -10.08%
===========================================
Files 133 133
Lines 6528 6529 +1
===========================================
- Hits 5776 5119 -657
- Misses 752 1410 +658
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
requested changes
Oct 24, 2022
JoanFM
requested changes
Oct 24, 2022
Member
|
Converting to |
NicholasDunham
approved these changes
Oct 24, 2022
JoanFM
requested changes
Oct 25, 2022
| query_vector=query_vector, | ||
| query_filter=filter, | ||
| search_params=None, | ||
| search_params=rest.SearchParams(**search_params), |
Member
There was a problem hiding this comment.
u have said that search_params is an Optional[Dict], but this is not true, if I pass None in search_params this will not work.
| q: 'QdrantArrayType', | ||
| limit: int = 10, | ||
| filter: Optional[Dict] = None, | ||
| search_params: Optional[Dict] = {}, |
Member
There was a problem hiding this comment.
set it as None as default and handle it properly
| query: 'QdrantArrayType', | ||
| limit: int = 10, | ||
| filter: Optional[Dict] = None, | ||
| search_params: Optional[Dict] = {}, |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
This PR is related to issue #666