Skip to content

feat: add sift1m to benchmark #614

Closed
AnneYang720 wants to merge 34 commits intodocarray:mainfrom
AnneYang720:chore-benchmark-refactor-298
Closed

feat: add sift1m to benchmark #614
AnneYang720 wants to merge 34 commits intodocarray:mainfrom
AnneYang720:chore-benchmark-refactor-298

Conversation

@AnneYang720
Copy link
Copy Markdown
Contributor

@AnneYang720 AnneYang720 commented Oct 12, 2022

Goals:

This PR will add sift1m dataset to benchmark scripts according to #298.
The code will continue from the work of #514 , #301 and #310.

  • adapt benchmark script to latest docarray
  • add sift1m dataset
  • reuse code in both random and dataset benchmarking
  • add code to generate benchmark recall lines
  • update benchmarking results

@AnneYang720 AnneYang720 marked this pull request as draft October 12, 2022 08:16
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2022

Codecov Report

Merging #614 (6abd9f1) into main (108b9d2) will decrease coverage by 4.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   88.48%   84.46%   -4.02%     
==========================================
  Files         133      133              
  Lines        6528     6528              
==========================================
- Hits         5776     5514     -262     
- Misses        752     1014     +262     
Flag Coverage Δ
docarray 84.46% <ø> (-4.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/reduce.py 26.92% <0.00%> (-73.08%) ⬇️
docarray/array/mixins/io/pushpull.py 32.50% <0.00%> (-60.00%) ⬇️
docarray/array/mixins/io/dataframe.py 41.66% <0.00%> (-58.34%) ⬇️
docarray/array/mixins/io/common.py 26.31% <0.00%> (-42.11%) ⬇️
docarray/array/storage/redis/find.py 63.20% <0.00%> (-25.48%) ⬇️
docarray/array/mixins/io/json.py 68.75% <0.00%> (-25.00%) ⬇️
docarray/array/storage/weaviate/find.py 65.33% <0.00%> (-21.34%) ⬇️
docarray/array/storage/elastic/find.py 75.92% <0.00%> (-20.38%) ⬇️
docarray/array/storage/annlite/find.py 84.61% <0.00%> (-15.39%) ⬇️
docarray/array/storage/qdrant/find.py 78.00% <0.00%> (-14.00%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnneYang720 AnneYang720 marked this pull request as ready for review October 21, 2022 07:13
@AnneYang720
Copy link
Copy Markdown
Contributor Author

This PR is moved to #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants