Skip to content

docs: add new benchmark page with SIFT1M dataset#691

Merged
JoanFM merged 82 commits intomainfrom
chore-benchmark-refactor-298
Nov 10, 2022
Merged

docs: add new benchmark page with SIFT1M dataset#691
JoanFM merged 82 commits intomainfrom
chore-benchmark-refactor-298

Conversation

@AnneYang720
Copy link
Copy Markdown
Contributor

@AnneYang720 AnneYang720 commented Oct 25, 2022

Goals:

This PR will add sift1m dataset to benchmark scripts according to #298.
The code will continue from the work of #514 , #301 and #310.

Change PR #614 to jina branch.

  • adapt benchmark script to latest docarray
  • add sift1m dataset
  • reuse code in both random and dataset benchmarking
  • add code to generate benchmark recall lines
  • update benchmarking results

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Copy Markdown
Member

@alaeddine-13 alaeddine-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait until weaviate PR is merged and use the same batch_size for all: 64
We also need to mention this fact in benchmark.md

@alexcg1 alexcg1 removed their assignment Nov 9, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-chore-benchmark-refactor-298--jina-docs.netlify.app 🎉

@JoanFM JoanFM changed the title feat: add sift1m to benchmark docs: add new benchmark page with SIFT1M dataset Nov 10, 2022
@JoanFM JoanFM merged commit 938c061 into main Nov 10, 2022
@JoanFM JoanFM deleted the chore-benchmark-refactor-298 branch November 10, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants