feat: Update weaviate to 1.16.0 and weaviate client to 3.9#734
Closed
dirkkul wants to merge 1 commit intodocarray:chore-benchmark-refactor-298from
Closed
Conversation
JoanFM
requested changes
Nov 8, 2022
| columns: Optional[Union[List[Tuple[str, str]], Dict[str, str]]] = None | ||
| distance: Optional[str] = None | ||
| # weaviate python client parameters | ||
| batch_size: Optional[int] = field(default=50) |
Member
There was a problem hiding this comment.
I am not sure if these parameters should be here in config, or should be passed as kwargs in the relevant methods.
@samsja @JohannesMessner @alaeddine-13 what is the pattern in other cases?
Member
There was a problem hiding this comment.
I think for batch_size it's always been in config.
The reason is we use batch_size in extend which handles batching for users.
We don't expose the parameter in extend's interface.
4ea16bf to
21ca6cd
Compare
Contributor
Author
|
I will split this into two PRs, where one targets main and another one targeting the benchmarking PR |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
This updates weaviate and weaviate-python-client to the latest version which include many speedups. Moreover multithreading of the client is enabled for the benchmarking.
Note: I work for weaviate/SeMi