Skip to content

fix(document): constructor overload#74

Merged
hanxiao merged 2 commits intodocarray:mainfrom
delgermurun:fix-document-constructor-overload
Jan 23, 2022
Merged

fix(document): constructor overload#74
hanxiao merged 2 commits intodocarray:mainfrom
delgermurun:fix-document-constructor-overload

Conversation

@delgermurun
Copy link
Copy Markdown
Contributor

@delgermurun delgermurun commented Jan 21, 2022

Removed duplicated @overload of Document.__init__ and added missing copy parameter.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2022

Codecov Report

Merging #74 (b5bcb91) into main (66ceeda) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   83.06%   83.08%   +0.01%     
==========================================
  Files          70       70              
  Lines        3402     3399       -3     
==========================================
- Hits         2826     2824       -2     
+ Misses        576      575       -1     
Flag Coverage Δ
docarray 83.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/document/__init__.py 77.27% <100.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf89c4...b5bcb91. Read the comment docs.

@hanxiao hanxiao merged commit d840d30 into docarray:main Jan 23, 2022
@delgermurun delgermurun deleted the fix-document-constructor-overload branch January 23, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants