Skip to content

fix(document): constructor overload #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 2 commits into from
Jan 23, 2022
Merged

fix(document): constructor overload #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
624e9ee
refactor(document): remove duplicated constructor overload
delgermurun Jan 21, 2022
b5bcb91
fix(document): add missing "copy" parameter to overload definition
delgermurun Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions docarray/document/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import overload, Dict, Optional, List, TYPE_CHECKING, Union, Sequence
from typing import overload, Dict, Optional, List, TYPE_CHECKING, Sequence

from .data import DocumentData, default_values
from .data import DocumentData
from .mixins import AllMixins
from ..base import BaseDCType

Expand All @@ -24,15 +24,7 @@ def __init__(self, _obj: Optional['Document'] = None, copy: bool = False):
def __init__(
self,
_obj: Optional[Dict],
field_resolver: Optional[Dict[str, str]] = None,
unknown_fields_handler: str = 'catch',
):
...

@overload
def __init__(
self,
_obj: Optional[Dict],
copy: bool = False,
field_resolver: Optional[Dict[str, str]] = None,
unknown_fields_handler: str = 'catch',
):
Expand Down