fix: allow backends not to implement list_like disabling#766
Merged
Conversation
Signed-off-by: Johannes Messner <[email protected]>
Codecov ReportBase: 88.13% // Head: 86.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 88.13% 86.61% -1.53%
==========================================
Files 133 133
Lines 6703 6703
==========================================
- Hits 5908 5806 -102
- Misses 795 897 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Johannes Messner <[email protected]>
JoanFM
requested changes
Nov 14, 2022
Co-authored-by: Joan Fontanals <[email protected]> Signed-off-by: Johannes Messner <[email protected]>
Member
Author
|
CI seems flaky (something going wrong during pip installing when preparing the tests); failures do not seem related to this PR |
JoanFM
approved these changes
Nov 14, 2022
anna-charlotte
pushed a commit
that referenced
this pull request
Nov 14, 2022
Signed-off-by: anna-charlotte <[email protected]>
anna-charlotte
pushed a commit
that referenced
this pull request
Nov 14, 2022
feat: add rgbd representation of 3d mesh
anna-charlotte
pushed a commit
that referenced
this pull request
Nov 14, 2022
feat: add rgbd representation of 3d mesh Signed-off-by: anna-charlotte <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple fix that makes it so storage backend implementations don't necessarily have to have a
_list_likeproperty.We still want to encourage all backends to implement that feature, but it won't outright fail.
Besides, I think it is a better pattern not to assume the existence of a certain field that is outside the Mixin's control.