Skip to content

fix: allow backends not to implement list_like disabling #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 18 commits into from
Nov 14, 2022
Merged

fix: allow backends not to implement list_like disabling #766

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9226633
fix(plot): be robust against non-existing subindices
JohannesMessner Aug 26, 2022
173c85c
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Aug 30, 2022
499ac9a
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Oct 4, 2022
73cf538
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Oct 17, 2022
ee310da
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Oct 26, 2022
29d22e7
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Oct 27, 2022
28e371c
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Oct 31, 2022
686fef0
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 4, 2022
30bd965
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 8, 2022
e75c57f
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 8, 2022
3055e63
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 9, 2022
697e513
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 9, 2022
60e31dd
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 10, 2022
483c274
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 11, 2022
1446da9
Merge remote-tracking branch 'origin/main' into main
JohannesMessner Nov 14, 2022
c6b1eaf
fix: handle backends not having list_like attribute
JohannesMessner Nov 14, 2022
8b53fa2
docs: format docstring
JohannesMessner Nov 14, 2022
6aed7b3
refactor: update docarray/array/storage/base/getsetdel.py
JohannesMessner Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docarray/array/storage/base/getsetdel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def _del_docs_by_slice(self, _slice: slice):
def _del_docs_by_mask(self, mask: Sequence[bool]):
"""This function is derived and may not have the most efficient implementation.
Override this function if there is a more efficient logic

:param mask: the boolean mask used for indexing
"""
ids = list(itertools.compress(self._offset2ids, (_i for _i in mask)))
Expand All @@ -129,7 +130,7 @@ def _del_docs_by_mask(self, mask: Sequence[bool]):
def _del_all_docs(self):
self._clear_subindices()
self._clear_storage()
self._offset2ids = Offset2ID(list_like=self._list_like)
self._offset2ids = Offset2ID(list_like=getattr(self, '_list_like', True))

def _del_docs_by_ids(self, ids):
"""This function is derived from :meth:`_del_doc_by_id`
Expand Down