Skip to content

feat: change pydantic model optional id#77

Merged
JoanFM merged 1 commit intomainfrom
optional-id-pydantic
Jan 24, 2022
Merged

feat: change pydantic model optional id#77
JoanFM merged 1 commit intomainfrom
optional-id-pydantic

Conversation

@JoanFM
Copy link
Copy Markdown
Member

@JoanFM JoanFM commented Jan 24, 2022

No description provided.

@JoanFM JoanFM requested a review from hanxiao January 24, 2022 12:01
@JoanFM JoanFM linked an issue Jan 24, 2022 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2022

Codecov Report

Merging #77 (922620e) into main (66ceeda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   83.06%   83.09%   +0.02%     
==========================================
  Files          70       70              
  Lines        3402     3401       -1     
==========================================
  Hits         2826     2826              
+ Misses        576      575       -1     
Flag Coverage Δ
docarray 83.09% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/document/pydantic_model.py 95.74% <100.00%> (+0.18%) ⬆️
docarray/document/__init__.py 77.27% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf89c4...922620e. Read the comment docs.

@JoanFM JoanFM merged commit 06cd577 into main Jan 24, 2022
@JoanFM JoanFM deleted the optional-id-pydantic branch January 24, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make id Optional in PydanticDocument

2 participants