Skip to content

feat: change pydantic model optional id #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Jan 24, 2022
Merged

feat: change pydantic model optional id #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docarray/document/pydantic_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class _NamedScore(BaseModel):


class PydanticDocument(BaseModel):
id: str
id: Optional[str]
parent_id: Optional[str]
granularity: Optional[int]
adjacency: Optional[int]
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_pydantic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,7 @@ def test_to_from_with_blob(protocol, to_fn, blob):
assert d.blob == r_d.blob
if d.blob:
assert isinstance(r_d.blob, bytes)


def test_pydantic_not_id():
_ = PydanticDocument()