Skip to content

hotfix: pull docarray with "username/da-name" format#807

Merged
samsja merged 1 commit intodocarray:hotfix-namespace-hubble-tempfrom
delgermurun:fix-docarray-pull-with-username
Nov 18, 2022
Merged

hotfix: pull docarray with "username/da-name" format#807
samsja merged 1 commit intodocarray:hotfix-namespace-hubble-tempfrom
delgermurun:fix-docarray-pull-with-username

Conversation

@delgermurun
Copy link
Copy Markdown
Contributor

Goals:

  • To fix FileNotFoundError: [Errno 2] No such file or directory: '.../username/test_name' error when pulling docarray with "username/da-name" formatted name
  • check and update documentation, if required. See guide

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (hotfix-namespace-hubble@1409e52). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head b29ad51 differs from pull request most recent head 315aa41. Consider uploading reports for the commit 315aa41 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                     @@
##             hotfix-namespace-hubble     #807   +/-   ##
==========================================================
  Coverage                           ?   82.04%           
==========================================================
  Files                              ?      133           
  Lines                              ?     6704           
  Branches                           ?        0           
==========================================================
  Hits                               ?     5500           
  Misses                             ?     1204           
  Partials                           ?        0           
Flag Coverage Δ
docarray 82.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

@samsja samsja changed the base branch from main to hotfix-namespace-hubble November 17, 2022 13:35
@delgermurun delgermurun force-pushed the fix-docarray-pull-with-username branch from 8ccbd74 to b29ad51 Compare November 17, 2022 13:51
@delgermurun delgermurun force-pushed the fix-docarray-pull-with-username branch from b29ad51 to 315aa41 Compare November 17, 2022 13:53
@delgermurun delgermurun requested a review from samsja November 17, 2022 14:30
@samsja samsja changed the base branch from hotfix-namespace-hubble to hotfix-namespace-hubble-temp November 18, 2022 14:28
@samsja samsja changed the title fix: pull docarray with "username/da-name" format hotfix: pull docarray with "username/da-name" format Nov 18, 2022
@samsja samsja merged commit 1eee388 into docarray:hotfix-namespace-hubble-temp Nov 18, 2022
@delgermurun delgermurun deleted the fix-docarray-pull-with-username branch November 21, 2022 08:57
samsja added a commit that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants