Skip to content

fix: pull docarray with username/da-name format#856

Merged
JoanFM merged 2 commits intodocarray:mainfrom
delgermurun:fix-docarray-pull-with-username
Dec 1, 2022
Merged

fix: pull docarray with username/da-name format#856
JoanFM merged 2 commits intodocarray:mainfrom
delgermurun:fix-docarray-pull-with-username

Conversation

@delgermurun
Copy link
Copy Markdown
Contributor

Goals:

@delgermurun delgermurun force-pushed the fix-docarray-pull-with-username branch from 9239058 to 765ee23 Compare November 28, 2022 10:09
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 28, 2022

Codecov Report

Base: 84.88% // Head: 83.40% // Decreases project coverage by -1.48% ⚠️

Coverage data is based on head (77c0103) compared to base (5fce6b6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   84.88%   83.40%   -1.49%     
==========================================
  Files         138      138              
  Lines        7067     7068       +1     
==========================================
- Hits         5999     5895     -104     
- Misses       1068     1173     +105     
Flag Coverage Δ
docarray 83.40% <0.00%> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/io/pushpull.py 23.07% <0.00%> (-52.79%) ⬇️
docarray/array/mixins/io/csv.py 23.68% <0.00%> (-65.79%) ⬇️
docarray/array/mixins/plot.py 28.13% <0.00%> (-39.83%) ⬇️
docarray/array/mixins/sample.py 90.90% <0.00%> (-9.10%) ⬇️
docarray/array/mixins/io/binary.py 92.15% <0.00%> (-4.58%) ⬇️
docarray/array/mixins/getattr.py 78.78% <0.00%> (-3.04%) ⬇️
docarray/array/storage/weaviate/backend.py 85.89% <0.00%> (+0.64%) ⬆️
docarray/array/mixins/setitem.py 82.50% <0.00%> (+0.83%) ⬆️
docarray/array/storage/redis/getsetdel.py 97.14% <0.00%> (+1.42%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoanFM JoanFM merged commit 52a07c0 into docarray:main Dec 1, 2022
@delgermurun delgermurun deleted the fix-docarray-pull-with-username branch December 1, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants