Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 87 87
Lines 3814 3811 -3
==========================================
- Hits 3165 3162 -3
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
numb3r3
reviewed
Jan 27, 2022
| return int(v) # parse int parameter | ||
| except ValueError: | ||
| try: | ||
| return float(v) # parse float parameter |
Contributor
There was a problem hiding this comment.
We can also check the parsed value, and raise exception then
v = float(v)
if math.isnan(v) or math.isinf(v):
raise ValueError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83