Skip to content

fix(document): fix feature hash mixin#85

Merged
hanxiao merged 1 commit intomainfrom
fix-any-hash
Jan 27, 2022
Merged

fix(document): fix feature hash mixin#85
hanxiao merged 1 commit intomainfrom
fix-any-hash

Conversation

@hanxiao
Copy link
Copy Markdown
Member

@hanxiao hanxiao commented Jan 27, 2022

close #84

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2022

Codecov Report

Merging #85 (a332bac) into main (1ed4ddd) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   82.98%   82.85%   -0.13%     
==========================================
  Files          87       87              
  Lines        3814     3815       +1     
==========================================
- Hits         3165     3161       -4     
- Misses        649      654       +5     
Flag Coverage Δ
docarray 82.85% <50.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/mixins/featurehash.py 79.24% <50.00%> (-9.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed4ddd...a332bac. Read the comment docs.

@hanxiao hanxiao linked an issue Jan 27, 2022 that may be closed by this pull request
@hanxiao hanxiao merged commit 95d9f5a into main Jan 27, 2022
@hanxiao hanxiao deleted the fix-any-hash branch January 27, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature hashing fails with float strings inf and nan

1 participant