perf: implement append to avoid invalidating id2offset#94
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.01%
==========================================
Files 98 98
Lines 4386 4390 +4
==========================================
+ Hits 3739 3743 +4
Misses 647 647
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hanxiao
reviewed
Feb 3, 2022
Comment on lines
+20
to
+27
| def append(self, value: 'Document'): | ||
| """Append `doc` to the end of the array. | ||
|
|
||
| :param value: The doc needs to be appended. | ||
| """ | ||
| self._data.append(value) | ||
| if not self._needs_id2offset_rebuild: | ||
| self._id_to_index[value.id] = len(self) - 1 |
Member
There was a problem hiding this comment.
can you implement faster extend as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slack discussion: https://jinaai.slack.com/archives/C02AC4T8Y5T/p1643893118678839