Skip to content

perf: implement append to avoid invalidating id2offset #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanxiao merged 2 commits into from
Feb 3, 2022
Merged

perf: implement append to avoid invalidating id2offset #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0823f6b
perf: implement append to avoid invalidating id2offset
alaeddine-13 Feb 3, 2022
3a15c8c
fix: add the correct offset
alaeddine-13 Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docarray/array/storage/memory/seqlike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ def insert(self, index: int, value: 'Document'):
"""
self._data.insert(index, value)

def append(self, value: 'Document'):
"""Append `doc` to the end of the array.

:param value: The doc needs to be appended.
"""
self._data.append(value)
if not self._needs_id2offset_rebuild:
self._id_to_index[value.id] = len(self) - 1
Comment on lines +20 to +27
Copy link
Copy Markdown
Member

@hanxiao hanxiao Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you implement faster extend as well?


def __eq__(self, other):
return (
type(self) is type(other)
Expand Down