Conversation
Signed-off-by: anna-charlotte <[email protected]>
Codecov ReportBase: 83.50% // Head: 85.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 83.50% 85.18% +1.67%
==========================================
Files 155 155
Lines 8051 8057 +6
==========================================
+ Hits 6723 6863 +140
+ Misses 1328 1194 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
ba8801e to
5c03bd7
Compare
Signed-off-by: anna-charlotte <[email protected]>
JoanFM
left a comment
There was a problem hiding this comment.
add a test to show that at least it does not break
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
d2eb4b4 to
e6fd102
Compare
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
@Joan I added a smoke test for the display function but I am getting this |
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
|
Update on test: removed test for display function again, because it always failed in the CI due to the pyglet window not being able to open when running in the CI, while passing locally |
JohannesMessner
left a comment
There was a problem hiding this comment.
Did you remove the test that you mention in the comment here?
| colors = np.tile(np.array([0, 0, 0]), (len(self.tensor), 1)) | ||
| for chunk in self.chunks: | ||
| if ( | ||
| 'name' in chunk.tags.keys() |
There was a problem hiding this comment.
Is 'name' a key that is already established in other parts of the code / other features? If not I think I would prefer a more descriptive key here
There was a problem hiding this comment.
We used 'name' for the vertices and faces chunks, too. I think it makes sense to use the same for both of them, to keep it simple for the user. Do you have a suggestion for what you would prefer over 'name'?
There was a problem hiding this comment.
no sounds good, let's keep it consistent
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Co-authored-by: samsja <[email protected]> Signed-off-by: Charlotte Gerhaher <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
@JohannesMessner Yes, removed it |
Signed-off-by: anna-charlotte <[email protected]>
e514334 to
1ec6896
Compare
|
📝 Docs are deployed on https://ft-feat-display-colored-point-cloud--jina-docs.netlify.app 🎉 |
Signed-off-by: anna-charlotte [email protected]
When displaying a point cloud, we want to additionally consider its colors, if those are available.
The point cloud tensor is stored in a Documents
.tensorfield. If colors are available store them in a chunkDocumentwithtags['name'] = 'point_cloud_colors'. The chunks tensor must be of shape (n_points, 3) or (n_points, 4), with a corresponding color for each point.display_point_cloud_tensor()