fix: value extraction of point cloud colors enum in display#995
fix: value extraction of point cloud colors enum in display#995JohannesMessner merged 7 commits intomainfrom
Conversation
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Codecov ReportBase: 85.18% // Head: 85.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 85.18% 85.04% -0.14%
==========================================
Files 155 155
Lines 8057 8057
==========================================
- Hits 6863 6852 -11
- Misses 1194 1205 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: anna-charlotte <[email protected]>
|
📝 Docs are deployed on https://ft-docs-fix-display-point-cloud--jina-docs.netlify.app 🎉 |
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
|
|
||
| for chunk in self.chunks: | ||
| if chunk.tags['name'] == MeshEnum.VERTICES: | ||
| if chunk.tags['name'] == MeshEnum.VERTICES.value: |
There was a problem hiding this comment.
| if chunk.tags['name'] == MeshEnum.VERTICES.value: | |
| if chunk.tags['name'] in [MeshEnum.VERTICES.value, MeshEnum.VERTICES] |
for sake of compatibility with previous version
There was a problem hiding this comment.
okay it was not released so not needed actually
There was a problem hiding this comment.
yes, I changed the Mesh class to MeshEnum(Enum) in a previous PR, but didn't adjust the enum value extraction accordingly. This PR hasn't been in a release yet, therefore no need to add the MeshEnum.VERTICES.
| if chunk.tags['name'] == MeshEnum.VERTICES.value: | ||
| vertices = chunk.tensor | ||
| if chunk.tags['name'] == MeshEnum.FACES: | ||
| if chunk.tags['name'] == MeshEnum.FACES.value: |
There was a problem hiding this comment.
| if chunk.tags['name'] == MeshEnum.FACES.value: | |
| if chunk.tags['name'] in [MeshEnum.VERTICES.value, MeshEnum.VERTICES] |
same here
| if ( | ||
| MeshEnum.VERTICES.value in name_tags | ||
| and MeshEnum.FACES.value in name_tags | ||
| ): |
There was a problem hiding this comment.
same lets support the old way as well
Fix code snippet for point cloud display with color:
Add
PointCloudEnum.COLORSas name tag instead of'point_cloud_colors'