Skip to content

enhance icc easyblock to inlude multipath include dir in $CPATH#1237

Merged
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:icc_usr_include_86_64-linux_gnu
Sep 4, 2017
Merged

enhance icc easyblock to inlude multipath include dir in $CPATH#1237
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:icc_usr_include_86_64-linux_gnu

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 3, 2017

requires easybuilders/easybuild-framework#2294

@akesandgren, @besserox, @vanzod, @geimer: feedback welcome, let me know if this works as expected...

@boegel boegel added this to the 3.4.0 milestone Sep 3, 2017
@besserox
Copy link
Copy Markdown
Contributor

besserox commented Sep 3, 2017

@boegel The logic looks good.
A few comments/questions:

  • Is the GCCCore dependency loaded when this is executed? (to make sure to use the right gcc)
  • Maybe you can update the comment (to not only refer to x86_64-linux-gnu)

I have not tested it though.

@besserox
Copy link
Copy Markdown
Contributor

besserox commented Sep 3, 2017

@boegel What's the easiest way to install this branch to try it?

@akesandgren
Copy link
Copy Markdown
Contributor

Yes, logic looks good. Will try to take it for a test spin if i get enough time tomorrow.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 3, 2017

@besserox That really depends on your setup, you can just try and inject the code added to module_generator.py in https://github.com/easybuilders/easybuild-framework/pull/2294/files#diff-8cdd2ad54096882655bd836265e8e26b, and then download the updated icc.py and use --include-easyblocks icc.py...

@easybuilders easybuilders deleted a comment from boegelbot Sep 3, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 3, 2017

After fixing the stupid mistake in the original PR, this seems to be working as intended; tested on in a Singularity container running Debian 9.1 using icc-2017.2.174-GCC-6.3.0-2.27.eb

@easybuilders easybuilders deleted a comment from boegelbot Sep 4, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 4, 2017

This should be good to go now that easybuilders/easybuild-framework#2294 is merged, pending confirmation from @akesandgren & @besserox...

@akesandgren
Copy link
Copy Markdown
Contributor

Yeah, my from-pr of #4618 worked with the framework/easyblock changes from this morning.

@besserox
Copy link
Copy Markdown
Contributor

besserox commented Sep 4, 2017

@boegel I've got a busy week. I won't have time to try it soon.

@akesandgren
Copy link
Copy Markdown
Contributor

And it worked with the new update_path based prepend/append_path framework too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants