Skip to content

enhance intel-compiler easyblock to include multiarch include dir in $CPATH#2477

Merged
bartoldeman merged 4 commits intoeasybuilders:developfrom
akesandgren:20210617104504_new_pr_VbDFHDgfBX
Jun 21, 2021
Merged

enhance intel-compiler easyblock to include multiarch include dir in $CPATH#2477
bartoldeman merged 4 commits intoeasybuilders:developfrom
akesandgren:20210617104504_new_pr_VbDFHDgfBX

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Jun 17, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

see #1237 for original PR

@akesandgren akesandgren added this to the next release (4.4.1) milestone Jun 17, 2021
@akesandgren akesandgren requested a review from boegel June 17, 2021 08:49
@zao
Copy link
Copy Markdown
Contributor

zao commented Jun 17, 2021

Test report by @zao

Overview of tested easyconfigs (in order)

  • SUCCESS intel-compilers-2021.2.0.eb
  • SUCCESS impi-2021.2.0-intel-compilers-2021.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
eb-u2004 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 3.8.5
See https://gist.github.com/5607a8bc31bd873a13e2986d9aa5dc4d for a full test report.

bartoldeman
bartoldeman requested changes Jun 19, 2021
View reviewed changes
Comment thread easybuild/easyblocks/i/intel_compilers.py Outdated
bartoldeman
bartoldeman approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 2caeb6c into easybuilders:develop Jun 21, 2021
@akesandgren akesandgren deleted the 20210617104504_new_pr_VbDFHDgfBX branch June 21, 2021 11:37
@akesandgren akesandgren mentioned this pull request Jun 22, 2021
Closed
@boegel boegel changed the title Enhance intel_compiler easyblock to inlude multipath include dir in $CPATH. See #1237 for original PR. enhance intel_compiler easyblock to inlude multipath include dir in $CPATH Jun 23, 2021
@boegel boegel changed the title enhance intel_compiler easyblock to inlude multipath include dir in $CPATH enhance intel_compiler easyblock to include multiarch include dir in $CPATH Jun 23, 2021
@boegel boegel changed the title enhance intel_compiler easyblock to include multiarch include dir in $CPATH enhance intel-compiler easyblock to include multiarch include dir in $CPATH Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @zao @bartoldeman