don't assume cmake arguments when configure_cmd is set in CMakeMake easyblock#1750
Merged
boegel merged 3 commits intoeasybuilders:developfrom Jul 4, 2019
Merged
Conversation
Member
Author
|
closing and reopening to trigger travis |
boegel
requested changes
Jul 2, 2019
Member
boegel
left a comment
There was a problem hiding this comment.
@migueldiascosta What use case did you hit that triggered you to make this change?
Member
Author
|
boegel
approved these changes
Jul 4, 2019
Member
|
Thanks for the fix @migueldiascosta! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even if
configure_cmdis simply a script runningcmake, it may not accept the flags inoptions_stringand thesrc_diras arguments, and as it is they cannot be removed - the proposed solution gives back control to the easyconfig, imho