{chem}[foss/2018b,intel/2018b] SALMON v1.2.1#8478
{chem}[foss/2018b,intel/2018b] SALMON v1.2.1#8478boegel merged 2 commits intoeasybuilders:developfrom
Conversation
|
Test report by @migueldiascosta |
| separate_build_dir = True | ||
|
|
||
| configure_cmd = "python ../SALMON-v.%(version)s/configure.py" | ||
| configopts = "FC='$MPIF90' CC='$MPICC' FFLAGS='$FFLAGS' CFLAGS='$CFLAGS' " |
There was a problem hiding this comment.
Wait, this doesn't make sense... If you use single quotes around $CFLAGS & co, they won't get expanded by the shell (it'll be a literal '$CFLAGS' value).
So, why does this work?! :)
There was a problem hiding this comment.
you're right... but this are arguments to the configure.py script, which then does:
define = ''
for k,v in dict.items():
define = '{0} -D {1}={2}'.format(define, k, v)
env = ''
for var in args:
(k, v) = var.split('=', 1)
env = '{0} {1}="{2}"'.format(env, k, v)
### configuration
comm = '{2} cmake {0} {1}'.format(define, SOURCE_DIR, env)
print(' $ %s' % comm)
os.system(comm)so in this case I suppose it's actually better that it is not expanded here, only in the cmake command executed by the configure.py script (?)
There was a problem hiding this comment.
Ah, that explains it... Thanks for the clarification! (also, ugh...)
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Verified that correct compiler & options are being used by checking log after adding |
|
Going in, thanks @migueldiascosta! |
(created using
eb --new-pr)requires easybuilders/easybuild-easyblocks#1750