Skip to content

correctly define comp.src in Bundle easyblock, to fix compatibility with easyblocks that leverage self.src#1777

Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom
boegel:bundle_fix_comp_src
Aug 13, 2019
Merged

correctly define comp.src in Bundle easyblock, to fix compatibility with easyblocks that leverage self.src#1777
wpoely86 merged 1 commit intoeasybuilders:developfrom
boegel:bundle_fix_comp_src

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 13, 2019

fix for bug reported by @klust on the EasyBuild Slack channel, when trying to use the CmpCp easyblock to install a Bundle component:

== 2019-08-13 13:11:06,237 build_log.py:163 ERROR EasyBuild crashed with an error (at ?:124 in __init__): Traceback (most recent call last):
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_framework-3.9.3-py2.7.egg/easybuild/main.py", line 112, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_framework-3.9.3-py2.7.egg/easybuild/framework/easyblock.py", line 3046, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_framework-3.9.3-py2.7.egg/easybuild/framework/easyblock.py", line 2956, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_framework-3.9.3-py2.7.egg/easybuild/framework/easyblock.py", line 2826, in run_step
    step_method(self)()
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_easyblocks-3.9.3-py2.7.egg/easybuild/easyblocks/generic/bundle.py", line 216, in install_step
    comp.run_step(step_name, [lambda x: getattr(x, '%s_step' % step_name)])
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_framework-3.9.3-py2.7.egg/easybuild/framework/easyblock.py", line 2826, in run_step
    step_method(self)()
  File "/apps/antwerpen/x86_64/centos7/EasyBuild/3.9.3/lib/python2.7/site-packages/easybuild_easyblocks-3.9.3-py2.7.egg/easybuild/easyblocks/generic/cmdcp.py", line 64, in build_step
    src = src['path']
KeyError: 'path'

@boegel boegel added the bug fix label Aug 13, 2019
@boegel boegel added this to the next release (3.9.4?) milestone Aug 13, 2019
@wpoely86 wpoely86 merged commit 9b6f75d into easybuilders:develop Aug 13, 2019
@boegel boegel deleted the bundle_fix_comp_src branch August 13, 2019 13:43
@boegel boegel mentioned this pull request Aug 13, 2019
Merged
@klust
Copy link
Copy Markdown

klust commented Aug 13, 2019

Tested it on my EasyConfig that caused problems, and it works. Reinstalled two more Bundle-based easyconfigs that do not use CmdCp and that also went without any problem.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

@klust Thanks a lot for the feedback! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.4

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @klust @wpoely86