Skip to content

{tools}[foss/2019a] Annif v0.40.0 w/ Python 3.7.2#8536

Merged
Micket merged 3 commits intoeasybuilders:developfrom
boegel:20190704185755_new_pr_Annif0400
Sep 30, 2019
Merged

{tools}[foss/2019a] Annif v0.40.0 w/ Python 3.7.2#8536
Micket merged 3 commits intoeasybuilders:developfrom
boegel:20190704185755_new_pr_Annif0400

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 4, 2019

(created using eb --new-pr)

@boegel boegel added the new label Jul 4, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/1e1ebbb8af08379ca94ed66b4d9b3796 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2633.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ae3d23976363bb8ef409a92cb75cc838 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2045.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4cdb3353e9eb1f0b6683b5a59481c49d for a full test report.

@boegel boegel added this to the 3.x milestone Jul 4, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Jul 5, 2019

Test report by @vanzod
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/8911534d17abea332a6ddd76d662c8ff for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Jul 5, 2019

@boegel pyrsistent is missing the checksum

Micket
Micket requested changes Jul 15, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/a/Annif/Annif-0.40.0-foss-2019a-Python-3.7.2.eb
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

@boegel pyrsistent is missing the checksum

@vanzod Hmm, the tests are supposed to catch missing checksums... :-/
I'll check why it's not...

@boegel boegel mentioned this pull request Aug 13, 2019
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

@boegel pyrsistent is missing the checksum

@vanzod Hmm, the tests are supposed to catch missing checksums... :-/
I'll check why it's not...

Bug found and fixed in easybuilders/easybuild-easyblocks#1778...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

(close/re-open to re-trigger Travis tests and check whether easybuilders/easybuild-easyblocks#1777 indeed causes the missing checksum to be reported...)

@boegel boegel closed this Aug 13, 2019
@boegel boegel reopened this Aug 13, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

Tests now indeed fail as expected 🎉

Checksums missing for one or more sources/patches of extension pyrsistent in Annif-0.40.0-foss-2019a-Python-3.7.2.eb: found 1 sources + 0 patches vs 0 checksums

Will fix the easyconfig (and add one for intel/2019a while I'm at it, since #8540 was fixed)...

@boegel boegel mentioned this pull request Aug 13, 2019
Closed
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3121.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/be8c646e627e7fcab34b16ca9af9e82e for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2029.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9598bdd04b299c77eb623d7c6f88d4b7 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2420.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/70d2bd2fee52b9b2b15ace4cf764a101 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 28, 2019

(re-triggering Travis checks...)

@boegel boegel closed this Sep 28, 2019
@boegel boegel reopened this Sep 28, 2019
@boegel boegel modified the milestones: 3.x, 4.x Sep 28, 2019
Micket
Micket approved these changes Sep 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Sep 30, 2019

Going in, thanks @boegel!

@Micket Micket merged commit c180ee5 into easybuilders:develop Sep 30, 2019
@boegel boegel modified the milestones: 4.x, next release (4.0.1) Sep 30, 2019
@boegel boegel deleted the 20190704185755_new_pr_Annif0400 branch September 30, 2019 17:53
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Sep 30, 2019

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
vera-c1 - Linux centos linux 7.6.1810, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/62add535f09028ecd3f7ff0e508f3781 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin left review comments

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @vanzod @Micket @verdurin