look for Python version directories with suffixes in ROOT easyblock#2010
look for Python version directories with suffixes in ROOT easyblock#2010lexming merged 1 commit intoeasybuilders:developfrom
Conversation
…entation adapted from blender.py.
lexming
left a comment
There was a problem hiding this comment.
Tested ROOT-6.14.06-foss-2018b-Python-3.6.6.eb from easybuilders/easybuild-easyconfigs#10324 and paths to Python installation are correctly set
-DPYTHON_INCLUDE_DIR=/apps/brussel/CO7/ivybridge-ib/software/Python/3.6.6-foss-2018b/include/python3.6m
-DPYTHON_LIBRARY=/apps/brussel/CO7/ivybridge-ib/software/Python/3.6.6-foss-2018b/lib/libpython3.6m.so
lexming
left a comment
There was a problem hiding this comment.
Tested with ROOT-6.14.06-foss-2018b-Python-2.7.15.eb and the paths to Python installation were correctly set to
-DPYTHON_INCLUDE_DIR=/apps/brussel/CO7/ivybridge-ib/software/Python/2.7.15-foss-2018b/include/python2.7
-DPYTHON_LIBRARY=/apps/brussel/CO7/ivybridge-ib/software/Python/2.7.15-foss-2018b/lib/libpython2.7.so
lexming
left a comment
There was a problem hiding this comment.
Both builds finished without issues.
LGTM
|
Going in, thanks @kelseymh ! |
|
Instead of copying |
|
@mboisson You are quite right, of course. Since this PR is already merged, I will open a new one with that improvement. |
|
I created a PR for the framework for it here already We only need the PR for the EasyBlocks (root.py and blender.py) |
|
I'll do that. Something I don't know how to deal with, though, is handling the cross-repository dependence. Should I just wait until your PR #3297 gets merged, and then submit mine? Or is there a way to specify the dependence as part of the PR process? Sorry for my GitHub ignorance :-/ |
|
I don't know that there is an official mechanism. I usually just comment on the PR that this PR requires that PR. |
You're very right, and I thought of that, but I had to admit I was being lazy at the time (we were close to the EasyBuild v4.2.0 release, and I wanted this fix included in it). Thanks for bringing this up, and helping out! |
Implementation adapted from blender.py. Addresses issue #2009 .