I'm probably being too simple-minded here. I think the "self" argument to find_glob_pattern needs to be dropped (since filetools.py isn't a class), and the "self.dry_run" condition should be removed, or modified to be a passed-in argument from root.py and blender.py.

sorry about that, my github was out-of-date, i totally missed the conversation

So, dry-run check at all seems a little bit strange to me; it's mostly used for functions that actually modify files and directories. This is just read only. I suppose it's just to avoid exceptions being thrown when expected directories aren't created due to a dry run?

The dryrun check is inherited from the code that was already in the two EasyBlocks. I did not want to remove it and risk breaking something.

Yeah I'm just not sure if the easyblock self.dry_run is really equivalent to if build_option('extended_dry_run'). Perhaps a input parameter is called for in that case.
As I don't really see the need for it in either case, I'd like input from a second maintainer.

Maybe @kelseymh can comment ?

@mboisson and @Micket The two are exactly the same:

Updated: the same build_option('extended_dry_run') construction is used in several of the other non-easyblock utilities, such as environment.py, elsewhere in filetools.py, github.py, and run.py.