make sure PythonBundle uses correct 'python' command in extensions filter + also add lib64/python*/site-packages to $PYTHONPATH (if it exists)#2075
Merged
wpoely86 merged 2 commits intoeasybuilders:developfrom Jun 9, 2020
Conversation
wpoely86
previously approved these changes
Jun 8, 2020
Member
|
I'm missing a test for this? |
Member
Author
… lib64/python*/site-packages directories into account when updating $PYTHONPATH in generated module file
Member
Author
|
Fixes confirmed with test reports in easybuilders/easybuild-easyconfigs#10754, @wpoely86 this should be good to go now... |
wpoely86
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only required for installations that don't use a proper Python dependency, where
pythonwas not the command used for installing it (butpython3was used instead), see for example easybuilders/easybuild-easyconfigs#10754.cc @teojgo