Skip to content

fix bug in PythonBundle: always add */site-packages subdirs to $PYTHONPATH when installing extensions#2081

Merged
lexming merged 2 commits intoeasybuilders:developfrom
boegel:pythonbundle_fix
Jun 24, 2020
Merged

fix bug in PythonBundle: always add */site-packages subdirs to $PYTHONPATH when installing extensions#2081
lexming merged 2 commits intoeasybuilders:developfrom
boegel:pythonbundle_fix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 17, 2020

This fixes a bug that was introduced in #2075.

Installing SciPy-bundle is broken currently for example, the installation of the scipy extensions fails because numpy can not be found, even though it is installed correctly.

@boegel boegel added the bug fix label Jun 17, 2020
@boegel boegel added this to the next release (4.2.2?) milestone Jun 17, 2020
ocaisa
ocaisa previously approved these changes Jun 17, 2020
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jun 17, 2020

Now that I see this, I'm a bit concerned about https://github.com/easybuilders/easybuild-framework/blob/develop/easybuild/framework/easyblock.py#L1405
Are there cases (such as a bundle) where this will come back to bite us?

Comment thread easybuild/easyblocks/generic/pythonbundle.py Outdated
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 17, 2020

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 17, 2020

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 24, 2020

Now that I see this, I'm a bit concerned about https://github.com/easybuilders/easybuild-framework/blob/develop/easybuild/framework/easyblock.py#L1405
Are there cases (such as a bundle) where this will come back to bite us?

If that's a problem then it should make the sanity check fail due to missing stuff in the module file?

In this particular case, we're only making sure that the module file that is used to set up the environment before installing extensions is correct.

The module file used during the sanity check is a fresh one, which should have the same contents as the final module file (since nothing is changed anymore when the sanity check kicks off, that's after (post)install and extensions steps).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 24, 2020

Fix confirmed with eb SciPy-bundle-2020.03-foss-2020a-Python-3.8.2.eb -f --include-easyblocks-from-pr 2081 after committing @lexming's suggestion, so this should be good to go...

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 24, 2020

Going in, thanks @boegel !

@lexming lexming merged commit 11258e3 into easybuilders:develop Jun 24, 2020
@boegel boegel deleted the pythonbundle_fix branch June 24, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants