Allow NAMD to be built on POWER, and also use the CUDA arch info#2113
Allow NAMD to be built on POWER, and also use the CUDA arch info#2113migueldiascosta merged 1 commit intoeasybuilders:developfrom
Conversation
|
Test reports available in easybuilders/easybuild-easyconfigs#11090 |
|
Going in, thanks @edmondac! |
| # see http://charm.cs.illinois.edu/manuals/html/charm++/A.html | ||
| 'charm_arch': [None, "Charm++ target architecture", MANDATORY], | ||
| 'charm_opts': ['--with-production', "Charm++ build options", CUSTOM], | ||
| 'namd_basearch': ['Linux-x86_64', "NAMD base target architecture (compiler family is appended", CUSTOM], |
There was a problem hiding this comment.
actually, if someone out there has been using namd_basearch in easyconfigs, this will break them, wouldn't it have been safer to keep the extra option with 'None' as default and then set it in the easyblock only when it's not set in the easyconfig?
There was a problem hiding this comment.
Agreed, we shouldn't remove custom easyconfig parameters, that's not a backwards compatible change (especially since in EasyBuild 4.x we complain about unknown easyconfig parameters).
I'll open a PR to fix this.
| elif arch == POWER: | ||
| basearch = 'Linux-POWER' | ||
|
|
||
| cuda = get_software_root('CUDA') |
There was a problem hiding this comment.
This won't work as expected, since dependencies are not loaded yet at this point, this should be done in prepare_step...
An easyconfigs PR for NAMD 2.14 will follow this PR