fix default value for custom 'namd_basearch' easyconfig parameter in NAMD easyblock#2123
Merged
migueldiascosta merged 4 commits intoeasybuilders:developfrom Aug 24, 2020
Conversation
boegel
commented
Aug 14, 2020
|
|
||
| cuda = get_software_root('CUDA') | ||
| if cuda: | ||
| basearch = '%s.cuda' % basearch |
Member
Author
Member
Author
There was a problem hiding this comment.
Fails with:
ERROR: Build of /tmp/eb-zuwacrgi/files_pr11090/n/NAMD/NAMD-2.14-fosscuda-2019b.eb failed
(err: "build failed (first 300 chars): Failed to patch arch/Linux-x86_64.cuda.tcl:
[Errno 2] No such file or directory: 'arch/Linux-x86_64.cuda.tcl' -> 'arch/Linux-x86_64.cuda.tcl.orig.eb'")
migueldiascosta
previously approved these changes
Aug 16, 2020
Member
migueldiascosta
left a comment
There was a problem hiding this comment.
lgtm regarding restoring the namd_basearch easyconfig parameter
but merging this will actually break the fosscuda easyconfig (as opposed to cuda being ignored in the basearch), how shall we proceed?
Member
Author
|
@migueldiascosta Should be fixed now, it simply doesn't make sense to add Tested with both easyconfigs from easybuilders/easybuild-easyconfigs#11090, as well as the ones in easybuilders/easybuild-easyconfigs#11114 |
|
|
||
| if self.cfg['namd_basearch'] is None: | ||
|
|
||
| self.log.info("namd_basearch not specified, so determining it based a CPU arch & CUDA dep...") |
Member
There was a problem hiding this comment.
I guess mentioning the CUDA dep here is misleading then
Member
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)fix for issue raised by @migueldiascosta in #2113