make sure self.start_dir is set to a full path before constructing installation command in RPackage easyblock#2125
Merged
boegel merged 1 commit intoeasybuilders:developfrom Sep 4, 2020
Conversation
boegel
reviewed
Sep 4, 2020
| if self.start_dir: | ||
| loc = os.path.join(self.ext_dir or os.path.sep, self.start_dir) | ||
| else: | ||
| loc = self.ext_dir or self.ext_src |
Member
There was a problem hiding this comment.
As a side effect of the changes in easybuilders/easybuild-framework#3426, this doesn't work as intended anymore...
By the time you reach this code, self.start_dir has already been changed to the value of self.ext_dir, because the existence check done in _set_start_dir on the relative path in self.start_dir has failed...
Member
There was a problem hiding this comment.
This was actually a bug introduced with easybuilders/easybuild-framework#3426, should be fixed with easybuilders/easybuild-framework#3435...
Member
|
Tested easybuilders/easybuild-easyconfigs#11136 on top of this + the fix in easybuilders/easybuild-framework#3435, works like a charm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
start_diris not prefixed for RPackage extensions, requiring the full path to be specified.this is fixed by prepending
start_dirwithext_dir.