Skip to content

determine start dir for extension from unpacked source directory of extension + enhance tests to capture bug#3435

Merged
zao merged 2 commits intoeasybuilders:developfrom
boegel:fix_start_dir_exts
Sep 4, 2020
Merged

determine start dir for extension from unpacked source directory of extension + enhance tests to capture bug#3435
zao merged 2 commits intoeasybuilders:developfrom
boegel:fix_start_dir_exts

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 4, 2020

Fix for bug introduced in #3426, which effectively makes start_dir values that were specified for extensions be totally ignored (because the existence check on the start_dir value is typically using a relative value but from the wrong location).

The source tarball for the barbar test easyconfig has been changed to catch this bug: the source file has been moved into a subdirectory src and a README file was added to ensure that the top-level directory is initially picked as start directory after unpacking.

edit: fixes problems like this which occur now when using framework develop when installing an easyconfig file that includes an extension with a custom value for start_dir:

== installing extension protobuf-python 3.6.1 (1/13)...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/easybuild_build/TensorFlow/1.13.1/foss-2018b-Python-3.6.6): build failed (first 300 chars): cmd " /software/Python/3.6.6-foss-2018b/bin/python setup.py build " exited with exit code 2 and output:
/software/Python/3.6.6-foss-2018b/bin/python: can't open file 'setup.py': [Errno 2] No (took 10 sec)

The specified 'start_dir': 'python' is blatantly ignored, and hence setup.py is not found...

Copy link
Copy Markdown
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changes seems in line with the discussion and tests are green.

@zao zao merged commit 7cdbc1b into easybuilders:develop Sep 4, 2020
@boegel boegel deleted the fix_start_dir_exts branch September 4, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants