determine start dir for extension from unpacked source directory of extension + enhance tests to capture bug#3435
Merged
zao merged 2 commits intoeasybuilders:developfrom Sep 4, 2020
Conversation
zao
approved these changes
Sep 4, 2020
Contributor
zao
left a comment
There was a problem hiding this comment.
LGTM
Changes seems in line with the discussion and tests are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for bug introduced in #3426, which effectively makes
start_dirvalues that were specified for extensions be totally ignored (because the existence check on thestart_dirvalue is typically using a relative value but from the wrong location).The source tarball for the
barbartest easyconfig has been changed to catch this bug: the source file has been moved into a subdirectorysrcand aREADMEfile was added to ensure that the top-level directory is initially picked as start directory after unpacking.edit: fixes problems like this which occur now when using framework
developwhen installing an easyconfig file that includes an extension with a custom value forstart_dir:The specified
'start_dir': 'python'is blatantly ignored, and hencesetup.pyis not found...