stop silently ignoring failing numpy tests#2238
stop silently ignoring failing numpy tests#2238migueldiascosta merged 1 commit intoeasybuilders:developfrom
Conversation
|
@Flamefire Can you update the scipy easyblock as well for this change? |
|
Done. And with SciPy-bundle-2019.03-foss-2019a.eb I get a failure due to a precision issue -.- Same with Those are very small failures, e.g. Numpy seems to be fine. Not sure what to do. I'd suggest I'll remove the scipy change so we have at least numpy tested |
|
Let's put it in a separate PR so we can still try to address it |
|
Was that test on POWER? Looks like this is not uncommon: |
f12a8b6 to
98832e2
Compare
|
No, this was on Intel and AMD x86 CPUs. Split out the SciPy stuff into #2241 |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
|
lgtm I' wondering if there should be a log message about inverting the return value, so if a future version of numpy changes the behaviour (again) and the test_steps fails although all tests pass, at least it would be immediately clear why (?) |
|
I expect the shown error message to be clear enough for that case. I would not clutter the log in anticipation of stuff that may or may not change and may or may not be obvious what changed. I mean: The test command is pretty clear: Run a test function and exit with the inverse of the result. As long as you remember that exit takes an error value and not a success value of course. |
|
Going in, thanks @Flamefire! |
This checks for any errors during the numpy test suite.
Supersedes #1744
Fixes #2237
Fixes #605