add support for ignoring numpy test result#2271
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Dec 8, 2020
Merged
Conversation
Member
Author
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
ocaisa
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in #2238 make the numpy easyblock trip over failing tests (rightfully so), which wasn't the case before.
A handful of
numpytests are failing in specific circumstances (like on an AMD Rome system when usingintel/2020a, see easybuilders/easybuild-easyconfigs#11836) which are likely going to be (very) difficult to fix (in this specific case, we're probably hitting a bug inimkl2020 update 1).The changes made here make it possible to opt-in to ignoring failing numpy test results (via a hook, for example), such that the installation can actually be completed.